Skip to content

⬆️ Require CMake 3.28 and reduce dependency builds - #998

Merged
burgholzer merged 1 commit into
mainfrom
codex/cmake-3-28
Sep 6, 2026
Merged

⬆️ Require CMake 3.28 and reduce dependency builds#998
burgholzer merged 1 commit into
mainfrom
codex/cmake-3-28

Conversation

@burgholzer

@burgholzer burgholzer commented Sep 6, 2026

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Description

Raise the minimum CMake version to 3.28, replace the conditional module-scanning workaround with the global setting, and use native FetchContent EXCLUDE_FROM_ALL/SYSTEM support for Core, JSON, and Taskflow. Remove the now-redundant Taskflow include-property rewrite and update the requirements documentation.

Prepared with GPT-5/Codex assistance under explicit maintainer authorization.

Validation

  • uvx nox -s lint
  • Release configure/build with CMake 4.4.2 and exactly 3.28.4
  • 124 unaffected tests pass with each version
  • The remaining stochastic test failure reproduces unchanged on origin/main (265 versus 211 ± 50)
  • Confirmed CMake 3.27 rejects configuration

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

Assisted-by: GPT-5 via Codex
@burgholzer burgholzer added dependencies Pull requests that update a dependency file c++ Anything related to C++ code labels Sep 6, 2026
@burgholzer burgholzer added github-actions Pull requests that update GitHub Actions code tooling Any issue or PR related to project tooling labels Sep 6, 2026
@burgholzer burgholzer self-assigned this Sep 6, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in MQT Simulation Sep 6, 2026
@burgholzer
burgholzer enabled auto-merge (squash) September 6, 2026 21:53
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@burgholzer
burgholzer merged commit 92cc4ae into main Sep 6, 2026
25 checks passed
@burgholzer
burgholzer deleted the codex/cmake-3-28 branch September 6, 2026 22:59
@github-project-automation github-project-automation Bot moved this from In Progress to Done in MQT Simulation Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code dependencies Pull requests that update a dependency file github-actions Pull requests that update GitHub Actions code tooling Any issue or PR related to project tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant