🐛 Make MLIR region moves failure-atomic - #2293
Merged
Merged
Conversation
burgholzer
approved these changes
Aug 31, 2026
burgholzer
left a comment
Member
There was a problem hiding this comment.
This LGTM and can happily go in soon.
simon1hofmann
enabled auto-merge (squash)
August 31, 2026 18:36
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Makes the shared conversion
moveRegionhelper failure-atomic.The helper previously moved the source region before asking the type converter
whether its block-argument signature was supported. A failed conversion therefore
left the source empty and the destination partially changed. It now computes the
signature conversion first and moves the region only after that succeeds.
This is one focused replacement for draft PR #2287 and addresses part of #2255.
Validation
git diff --check— passedChecklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).AI assistance disclosure: Codex extracted this focused change from the
authorized #2255 audit, validated it, and drafted this description.