Skip to content

🐛 Make MLIR region moves failure-atomic - #2293

Merged
simon1hofmann merged 1 commit into
mainfrom
codex/2255-move-region-atomic
Aug 31, 2026
Merged

🐛 Make MLIR region moves failure-atomic#2293
simon1hofmann merged 1 commit into
mainfrom
codex/2255-move-region-atomic

Conversation

@simon1hofmann

@simon1hofmann simon1hofmann commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

🤖 AI text below 🤖

Description

Makes the shared conversion moveRegion helper failure-atomic.

The helper previously moved the source region before asking the type converter
whether its block-argument signature was supported. A failed conversion therefore
left the source empty and the destination partially changed. It now computes the
signature conversion first and moves the region only after that succeeds.

This is one focused replacement for draft PR #2287 and addresses part of #2255.

Validation

  • new failure-atomic regression — 1/1 passed
  • full QC-to-QCO suite — 170/170 passed
  • formatting, commit hooks, and git diff --check — passed

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

AI assistance disclosure: Codex extracted this focused change from the
authorized #2255 audit, validated it, and drafted this description.

@simon1hofmann simon1hofmann self-assigned this Aug 31, 2026
@simon1hofmann simon1hofmann added c++ Anything related to C++ code code quality Code quality improvements fix Fix for something that isn't working MLIR Anything related to MLIR skip-changelog Changes that do not need to show up in the changelog labels Aug 31, 2026
@burgholzer burgholzer added this to the MLIR Support milestone Aug 31, 2026

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and can happily go in soon.

@simon1hofmann
simon1hofmann enabled auto-merge (squash) August 31, 2026 18:36
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@simon1hofmann
simon1hofmann merged commit 62cf155 into main Aug 31, 2026
35 of 64 checks passed
@simon1hofmann
simon1hofmann deleted the codex/2255-move-region-atomic branch August 31, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code code quality Code quality improvements fix Fix for something that isn't working MLIR Anything related to MLIR skip-changelog Changes that do not need to show up in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants