🐛 Preserve static-qubit isolation during cleanup - #2291
Merged
Conversation
Keep qc.static operations inside their nearest IsolatedFromAbove scope so cleanup does not create invalid captures. Assisted-by: GPT-5.6 Sol via Codex
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Prevents the
HoistStaticQubitcleanup pattern from movingqc.staticacrossan
IsolatedFromAboveboundary.A zero-operand static root nested inside an isolated operation previously could
be moved to the surrounding function entry block, leaving its nested users with
an invalid capture from above. The pattern now hoists only when the function is
the operation's nearest isolation scope.
This is one focused replacement for draft PR #2287 and addresses part of #2255.
Validation
mqt-core-mlir-unittest-qc-ir --gtest_brief=1— 339/339 passeduvx nox -s lint— passedgit diff --check origin/main...HEAD— passedChecklist
If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).AI assistance disclosure: Codex extracted this focused change from the
authorized #2255 audit, validated it, and drafted this description.