🔥 Remove console scripts whose target modules no longer exist - #1011
Merged
burgholzer merged 2 commits intoSep 6, 2026
Merged
Conversation
`[project.scripts]` still declared two entry points inherited from
mqt.bench v1:
"create_mqt_bench_zip" = "mqt.bench.utils:create_zip_file"
"generate_mqt_bench" = "mqt.bench.benchmark_generator:generate"
Both target modules were deleted during the v2 refactor, so every
`pip install mqt.bench` puts two executables on PATH that fail
immediately with `ModuleNotFoundError`. Verified against the published
2.2.3 wheel, whose `entry_points.txt` declares all four scripts while
neither module is contained in the archive.
The remaining `mqt-bench` and `mqt.bench.cli` entry points are
unaffected.
Assisted-by: Claude Opus 4.8 via Claude Code
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Assisted-by: Claude Opus 4.8 via Claude Code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
[project.scripts]still declares two console scripts inherited from mqt.bench v1 whose target modules were removed during the v2 refactor:Neither
src/mqt/bench/utils.pynorsrc/mqt/bench/benchmark_generator.pyexists onmain(nor in package form), and a repo-wide grep forcreate_zip_file,mqt.bench.utilsandbenchmark_generatormatches only those two lines — nothing insrc/,tests/,docs/, or the workflows refers to them. Everypip install mqt.benchtherefore puts two executables onPATHthat fail immediately.This PR deletes those two lines.
mqt-benchandmqt.bench.cliare untouched.Reproduction against the published 2.2.3 wheel
Installed
mqt_bench-2.2.3-py3-none-any.whlfrom PyPI (with all dependencies) into a clean venv. Itsentry_points.txtdeclares four scripts while the archive contains neither module:Running them:
Verification of the fix
Resolving every declared entry point against the installed package, before and after:
Built a wheel from the patched tree —
entry_points.txtnow contains onlymqt-benchandmqt.bench.cli— installed it, and confirmed the venv's scripts directory holds exactly those two, withmqt-bench --level alg --algorithm ghz --num-qubits 3still emitting QASM.python -m pytest tests/test_cli.py→ 19 passed.Not a breaking change
src/mqt/bench/utils.pyandsrc/mqt/bench/benchmark_generator.pyare absent at every v2 tag (v2.0.0,v2.0.1,v2.1.0,v2.2.0,v2.2.3— all return 404). These two executables have never functioned in any v2 release, so nothing can depend on them and no upgrade-guide entry is warranted.Checklist
tests/test_cli.pyalready covers the two surviving entry points and passes.tests/test_cli.py, 19 passed) and via the wheel build above; awaiting CI.If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).AI disclosure: this change was prepared with Claude Code (Claude Opus 4.8) under my explicit authorization for this scope. The agent located the stale entry points, produced the two-line diff, and ran the reproduction and verification pasted above; I reviewed the diff and the evidence and take responsibility for the contribution. The commit carries an
Assisted-by:trailer.🤖 Generated with Claude Code