Repository navigation
fix(invoice)!: hash stored signed XML - #52
Merged
Merged
Conversation
BREAKING CHANGE: signed hash_base64() hashes stored XML; CLI generate-hash hashes input XML directly. Imported documents can produce different digests. The embedded invoice_hash() accessor remains unchanged. No model-hash compatibility method is added.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Description
Imported signed invoices can produce the wrong document hash because
hash_base64()reserializes their parsed model. Hash the stored XML directly sosigned.hash_base64()equalsXml.hash(signed.xml())across bindings. CLIgenerate-hashalso hashes its input XML directly.Behavioral breaking change: imported documents can produce different digests. Finalized invoices still hash their emitted XML, and
invoice_hash()still returns the embedded digest. No model-hash compatibility method is added. Digest equality alone does not verify signature authenticity.Validation
Checklist