Update Android Components to 20260518093736 and handle breaking changes#4307
Conversation
| android:layout_height="wrap_content" | ||
| android:layout_gravity="end|bottom" | ||
| android:src="@drawable/mozac_ic_font" | ||
| android:src="@drawable/mozac_ic_reader_view_24" |
There was a problem hiding this comment.
Same change as for Fenix - https://phabricator.services.mozilla.com/D300515
| android:text="@string/mozac_feature_addons_settings" | ||
| android:textSize="18sp" | ||
| app:drawableStartCompat="@drawable/mozac_ic_preferences" | ||
| app:drawableStartCompat="@drawable/mozac_ic_settings_24" |
There was a problem hiding this comment.
Same change as for Fenix - https://phabricator.services.mozilla.com/D300514
| icon = DrawableMenuIcon( | ||
| context, | ||
| mozilla.components.ui.icons.R.drawable.mozac_ic_stop, | ||
| mozilla.components.ui.icons.R.drawable.mozac_ic_cross_24, |
There was a problem hiding this comment.
Same change as for Fenix - https://phabricator.services.mozilla.com/D300519
| .collect { promptRequest -> | ||
| when (promptRequest) { | ||
| is WebExtensionPromptRequest.AfterInstallation -> { | ||
| if (promptRequest is WebExtensionPromptRequest.AfterInstallation) { |
There was a problem hiding this comment.
Replaced the exhaustive when check with a simpler if check here
Since there is no immediate plan to support WebExtensionPromptRequest.InstallationRequested in RB also.
Future WebExtensionPromptRequest changes will need to be handled in the below handlePermissions so new changes will require thinking about how to handle them in RB so this change will not lead to ignoring all future updates.
Mugurell
left a comment
Mugurell
left a comment
There was a problem hiding this comment.
Added some extra details.
Mugurell
force-pushed
the
20260518093736_update
branch
from
4838817 to
affec55
Compare
Merge Queue Status
This pull request spent 27 seconds in the queue, including 5 seconds running CI. Required conditions to merge
|
3 participants
This supersedes #4306