Repository navigation
feat(statements): add adjustments to the statement model - #398
Merged
michaelabbott25 merged 2 commits intoOct 29, 2026
Merged
michaelabbott25 merged 2 commits into
michaelabbott25 merged 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michaelabbott25
requested review from
InfernoJJ,
adamdecaf and
wadearnold
as code owners
October 28, 2026 18:32
![moov-review-bot[bot]](https://avatars.githubusercontent.com/in/4053684?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
🤖 This pull request adds adjustment fees to the statement models. It adds the AdjustmentFees and BillingAdjustment structures. It also adds a unit test to verify the new structures. We recommend that you add omitempty to the JSON tags of the new structures. This makes the code consistent and prevents the serialization of empty fields. — Gemini
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
InfernoJJ
approved these changes
Oct 29, 2026
AnthonyEnr1quez
approved these changes
Oct 29, 2026
michaelabbott25
deleted the
car-4965-billing-statements-updates-to-statements-api-with
branch
October 29, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
What
Adjustments *AdjustmentFeestoStatement, with the JSON keyadjustments.AdjustmentFeestype (itemsandtotal) and theBillingAdjustmenttype (feeName,count,amount). ABillingAdjustmentamount is negative for a credit.TestStatement_Adjustments. It decodes a statement with adjustments through the strict decoder, including a negative amount.Why
CAR-4965: the statements API now returns an
adjustmentssection (moovfinancial/billing-statements#92). The section is in every moov-api version since moov-api v5.0.0. The test client decodes withDisallowUnknownFields, so a statement with adjustments fails to decode without this field.Notes
pkg/moovpackage, not in apkg/mvYYMMpackage, because every API version has the field.BillingAdjustmentmatches the moov-api spec. The API also has an unrelatedadjustmentsdomain, so the nameAdjustmentcould cause a conflict later.— Claude
🤖 Generated with Claude Code