Conversation
Dividing by zero or taking the reciprocal of zero previously produced an invalid 1/0 value via new_unchecked. Both operators now panic with a clear message, and div_checked/reciprocal_checked raise RationalError for callers that want to handle the failure. Add regression tests for both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dividing by zero or taking the reciprocal of zero previously produced an invalid 1/0 value. Panic with a clear message at both call sites, and guard
op_div/reciprocalas a defense-in-depth invariant check. Add panic regression tests for both cases.#266