Mark API-acyclic container types as cycle-free - #3970
Open
Yu-zh wants to merge 1 commit into
Open
Conversation
Yu-zh
marked this pull request as ready for review
August 3, 2026 14:45
Yu-zh
force-pushed
the
Yu-zh/cycle-free-annotation
branch
from
August 4, 2026 02:01
a8fb5a6 to
20f1d28
Compare
Collaborator
Coverage Report for CI Build 5726Coverage remained the same at 90.458%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#unsafe_cycle_freeto recursive container representations that cannot form cycles through their public APIsRationale
These types are structurally recursive and therefore look cycle-capable to conservative analysis, but their exposed APIs do not permit constructing reference cycles. The annotations make that invariant explicit without changing the public API or observable behavior.
Validation
moon info(no public interface changes)moon fmtmoon check --warn-list +unnecessary_annotationmoon test— 7,000 tests passed