Skip to content

fix(server): return INVALID_PARAMS for unknown prompt in prompts/get #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
latent-9 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

fix(server): return INVALID_PARAMS for unknown prompt in prompts/get #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...in/io/modelcontextprotocol/kotlin/sdk/integration/kotlin/AbstractPromptIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,8 +698,8 @@ abstract class AbstractPromptIntegrationTest : KotlinTestBase() {

val expectedMessage = "Prompt not found: non-existent-prompt"

withClue("Exception code should be INTERNAL_ERROR: -32603") {
exception.code shouldBe -32603
withClue("Exception code should be INVALID_PARAMS: ${RPCError.ErrorCode.INVALID_PARAMS}") {
exception.code shouldBe RPCError.ErrorCode.INVALID_PARAMS
}
withClue("Unexpected error message for non-existent prompt") {
exception.message shouldBe expectedMessage
Expand Down
5 changes: 4 additions & 1 deletion kotlin-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/Server.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,10 @@ public open class Server(
val prompt = promptRegistry.get(requestParams.name)
?: run {
logger.error { "Prompt not found: ${requestParams.name}" }
throw IllegalArgumentException("Prompt not found: ${requestParams.name}")
throw McpException(
code = RPCError.ErrorCode.INVALID_PARAMS,
message = "Prompt not found: ${requestParams.name}",
)
}
return prompt.run {
session.clientConnection.messageProvider(request)
Expand Down