fix(cli): warn when auth validation falls back to API#1209
Merged
inimaz merged 1 commit intoMay 27, 2026
Conversation
Log a warning when local CLI access-token validation is skipped because the auth server cannot be reached, while preserving the existing availability fallback. Fixes mlco2#1208
31eb66b to
65e5f05
Compare
Contributor
Author
|
Rebased this branch onto the current Local verification after the rebase: GitHub currently reports no check rows for this branch yet. |
inimaz
approved these changes
May 27, 2026
Collaborator
inimaz
left a comment
There was a problem hiding this comment.
Nice addition thanks @puneetdixit200 !
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
=======================================
Coverage 88.92% 88.93%
=======================================
Files 45 45
Lines 4306 4309 +3
=======================================
+ Hits 3829 3832 +3
Misses 477 477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Log a warning when local CLI access-token validation is skipped because the auth server cannot be reached. This preserves the existing offline/flaky-network fallback while making it explicit that token freshness was not proven locally and the API will make the final authorization decision.
Related Issue
Fixes #1208
Motivation and Context
The existing fallback is useful for availability, but silent success makes the path look like a completed local validation. A warning keeps the behavior unchanged while surfacing the caveat from the issue.
How Has This Been Tested?
Red before implementation:
Green after implementation:
Screenshots (if appropriate):
N/A
Types of changes
AI Usage Disclosure
OpenAI GPT-5 generated the small code/test change and PR text under explicit human-directed issue-fix constraints. I reviewed the touched auth path, preserved existing fallback behavior, and verified the change with the commands listed above.
Checklist: