fix(start.mjs): remove chdir - #974
Open
xav-ie wants to merge 2 commits into
Open
Conversation
Moving cwd into the plugin dir confuses tools that read it. Unused.
xav-ie
marked this pull request as ready for review
July 19, 2026 01:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why / How
On startup the server changed its working directory into the plugin install
directory. That directory then leaks into any tool that reads a process's
working directory to find where the agent is working, for example a terminal
multiplexer opening a new split there instead of in the project. Nothing depends
on the change of directory, so remove it.
Affected platforms
Server startup path; client-agnostic. No behavior change to project resolution.
Test plan
A guard that the server no longer changes directory, and a check that project
resolution still returns the project when the process starts in the plugin
directory.
Checklist
npm testpassesnpm run typecheckpassesnextbranch (unless hotfix)