fix: pest roof-AOTV freeze and camera level-out#50
Draft
nnasko wants to merge 1 commit into
Draft
Conversation
- completeRoofAotv() no longer freezes the destroyer: the cosmetic camera level-out is wrapped so a throw can never block the state transition, which is the only exit from AOTV_TO_ROOF (a swallowed throwable silently stalled the destroyer when a plot had no roof). - After the roof climb the camera is levelled from its ~88-degree crane back to horizontal before moving toward pests, so the hand-off no longer looks robotic.
nnasko
marked this pull request as draft
July 24, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completeRoofAotv()is the only way out of theAOTV_TO_ROOFstate, and some callers wrap it incatch (Throwable). The camera level-out added for the hand-off could throw and get swallowed, silently stalling the pest destroyer (seen when a plot had open sky above the landing spot). The level-out is now isolated in its own guarded block so it can never prevent the state transition, and logs the error if it ever fires.Testing
Verified in-game: a plot with no roof no longer freezes the destroyer, and the camera levels out after the roof climb instead of moving off craned upward.