Skip to content

Update delete-entities.md - #3245

Merged
AnthonyTsu1984 merged 3 commits into
milvus-io:v2.5.xfrom
JavaLeb:patch-1
Oct 27, 2026
Merged

AnthonyTsu1984 merged 3 commits into
milvus-io:v2.5.xfrom
JavaLeb:patch-1

Conversation

@JavaLeb

@JavaLeb JavaLeb commented Jul 17, 2025

Copy link
Copy Markdown

'purple_4976 lacks a single quote on the right side. for example: filter("color in ['red_7025', 'purple_4976]") -> filter("color in ['red_7025', 'purple_4976']")

'purple_4976 lacks a single quote on the right side. for example:
filter("color in ['red_7025', 'purple_4976]") -> filter("color in ['red_7025', 'purple_4976']")
@sre-ci-robot

Copy link
Copy Markdown

Welcome @JavaLeb! It looks like this is your first PR to milvus-io/milvus-docs 🎉

@JavaLeb

JavaLeb commented Jul 17, 2025

Copy link
Copy Markdown
Author

my first!

@zhanshuyou
zhanshuyou force-pushed the v2.5.x branch 2 times, most recently from 9087db6 to 1d3ea4f Compare November 20, 2025 02:41
@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AnthonyTsu1984, JavaLeb

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: AnthonyTsu1984 <wenjia.tu@zilliz.com>
@AnthonyTsu1984

Copy link
Copy Markdown
Collaborator

Thanks @JavaLeb for catching this! Great find.

I pushed one additional commit to this PR that applies the same fix to the Python snippet just above (filter="color in ['red_7025', 'purple_4976]" was missing the closing single quote after 4976 as well).

Heads-up for follow-up: the v2.6.x and v3.0.x branches carry three identical bad quotes each (Python L34, Java L56, Node.js L72 in delete-entities.md) — those will be fixed separately. The Node.js snippet on this branch (L72) also still has the same typo and will be covered by that follow-up.

@AnthonyTsu1984

Copy link
Copy Markdown
Collaborator

Thanks for catching this! Two notes on the current state of v2.5.x:

  1. The Java hunk is stale. The same fix for the Java example (line 56) already landed on v2.5.x in 09dee8d (2025-07-18), so only the Python hunk in this PR is still needed. You may want to rebase so it merges cleanly.
  2. One occurrence is missed. The Node.js example has the same typo at line 72: filter: "color in ['red_7025', 'purple_4976]" — also missing the closing single quote. Could you include it?

I've opened #3732 to fix all three occurrences on v2.6.x (v3.0.x is already correct).

Signed-off-by: AnthonyTsu1984 <wenjia.tu@zilliz.com>
@AnthonyTsu1984
AnthonyTsu1984 merged commit 977c89d into milvus-io:v2.5.x Oct 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants