Repository navigation
Do not activate for task terminal - #964
Closed
Anthony Kim (anthonykim1) wants to merge 1 commit into
Closed
Anthony Kim (anthonykim1) wants to merge 1 commit into
Anthony Kim (anthonykim1) wants to merge 1 commit into
Conversation
Anthony Kim (anthonykim1)
added
bug
Anthony Kim (anthonykim1)
marked this pull request as ready for review
November 6, 2025 09:03
Contributor
|
Let's do the fix in core: microsoft/vscode#275782 |
Contributor
|
Also ideally the python extension(s) wouldn't attempt to activate these, there's a long standing problem with the processId API though so I worry about this fix introducing hard to diagnose bugs: microsoft/vscode#91905 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: microsoft/vscode#275667
We'd probably want to switch over to more reliable long term approach like microsoft/vscode#234440 in the future though. /cc Megan Rogge (@meganrogge) I think we can either add the api to tell if terminal is task terminal, or just straight up block extension from contributing commands to task terminal.
I don't know how aggressive the later would be, maybe some extension actually wants to contribute to task terminal via input?