SimpleDebounce should be a disposable

This should be disposable:

https://github.com/microsoft/vscode-python-environments/blob/baad0daaa2e01f31ba507176e889bdfaf30d4cff/src/common/utils/debounce.ts#L1-L23

dispose's impl should be:

    public dispose() {
        if (this.timeout) {
            clearTimeout(this.timeout);
        }
    }

Not having this means that if the debouncer's job is done while the setTimeout is active, it will still fire again.

An example of this in practice is if the extension is disabled it should immediately dispose everything. Another example is the transient usage in #952

The agent encountered an error and was unable to start working on this issue: This may be caused by a repository ruleset violation. See granting bypass permissions for the agent, or please contact support if the issue persists. (Request id: FB5D:F78D0:9F538F:A1FF4D:6A39ED43)

The agent encountered an error and was unable to start working on this issue: This may be caused by a repository ruleset violation. See granting bypass permissions for the agent, or please contact support if the issue persists. (Request id: 93F2:F9C18:849F24:B21DEA:6A3AB5C0)

🤖 Thanks for the report. The requested disposable implementation was added in 7d52871 through #952 and shipped in v1.12.0. SimpleDebounce now extends Disposable, and dispose() clears any pending timeout, so this is resolved.

Navigation Menu

Repository navigation

SimpleDebounce should be a disposable #954

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

SimpleDebounce should be a disposable #954

Description

Activity

Copilot commented on Jun 23, 2026

Copilot commented on Jun 23, 2026

eleanorjboyd commented on Sep 23, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions