Allow Exact Match For Filters

[tthornton3-chwy]

I was having cases where filters were matching inappropriately, for example with composite builds. This lets you have an exact match syntax. I know it's a bit niche, but I do think it's useful/I personally use it!

[tthornton3-chwy]

@microsoft-github-policy-service agree

[Changyong Gong (chagong)]

Thanks, this is a reasonable addition and the trailing-separator approach is backward compatible. One blocker and two smaller asks before merge:

Windows separator gap. The typical config form is !${workspaceFolder}/build/classes/ — after resolution that's an absolute path with forward slashes and a trailing /. Since it's absolute, path.join is skipped, so on Windows exclude.endsWith('\\') is false and exact-match silently never triggers. A Windows user would have to hand-write backslashes. Suggest making the check separator-agnostic and running it before normalization:

if (/[\\/]$/.test(exclude)) {
    exclude = exclude.slice(0, -1);
    isDirect = true;
} else {
    isDirect = this.isFilePath(exclude);
}

Docs. The trailing-slash convention isn't discoverable — can you update java.debugger.launch.classPaths.exclude and modulePaths.exclude in package.nls.json to mention it? It's also slightly counter-intuitive (a trailing slash usually implies a directory/prefix, here it means exact match), so a clear note helps.

Test. A small unit test covering the new exact-match path in filterExcluded would be good given this logic is filesystem-sensitive and currently untested.

[tthornton3-chwy]

Changyong Gong (@chagong) I finally got around to addressing the (very good!) feedback :) Can you re-take a peek?

[tthornton3-chwy]

before normalization, and using the exact code-block suggested, per feedback!

[Changyong Gong (chagong)]

The revised Windows separator handling and tests address the earlier feedback, but the trailing-separator comparison and documentation wording still need adjustment before merge.

[Changyong Gong (chagong)]

Could you normalize trailing separators consistently on both sides before this exact comparison? Currently, ["C:\\workspace\\lib\\", "!C:\\workspace\\lib\\"] leaves the separator on r but removes it from excludedPath, so the directory is not excluded. Please also add forward-slash and backslash tests where the included entry ends in a separator, taking care not to alter filesystem roots.

[Changyong Gong (chagong)]

This should say “A trailing slash or backslash will treat the path as an exact match.” The current wording suggests that any slash triggers exact matching, while the implementation only checks the final character. Please make the same change to the classPaths.exclude description.