CoR: Always ensure deploy skills are in the workspace and record their versions in telemetry - #1657
Open
Matthew Fisher (MicroFish91) wants to merge 2 commits into
Open
CoR: Always ensure deploy skills are in the workspace and record their versions in telemetry#1657Matthew Fisher (MicroFish91) wants to merge 2 commits into
Matthew Fisher (MicroFish91) wants to merge 2 commits into
Conversation
…elemetry The deploy prerequisite gate previously treated a global `~/.agents` copy of the `azure-prepare` skill as sufficient, so a user with the skill installed globally but not in their workspace never got a workspace copy. Telemetry also only recorded a `copilotForAzureSkillInstalled` boolean, with no per-skill version. - Key the "already installed / skip install" check off the workspace `.agents` copy only. A global copy no longer short-circuits the local install, so the gate always guarantees a workspace copy. Existing local copies are not force-refreshed. - Record the semver of `azure-prepare`, `azure-validate`, and `azure-deploy` parsed from each skill's `SKILL.md` frontmatter `metadata.version`, on every deploy-stage run. Missing/unreadable versions record as `unknown` and never crash the gate. `computedHash` / `skills-lock.json` values are deliberately not recorded. - Add unit tests for the workspace-only detection and `metadata.version` parsing, including the missing-version fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Matthew Fisher (MicroFish91)
marked this pull request as draft
August 5, 2026 20:15
Matthew Fisher (MicroFish91)
changed the title
Matthew Fisher (MicroFish91)
left a comment
Matthew Fisher (MicroFish91)
left a comment
Contributor
Author
There was a problem hiding this comment.
Feedback for my agent
Per PR review feedback: - Copilot on Rails is single-root, so the workspace `.agents` helpers now default to `workspaceFolders?.[0]` and pass a single root instead of an array. Renamed `getWorkspaceAgentsRoots` -> `getWorkspaceAgentsRoot` (returns `Uri | undefined`) and `skillExistsInRoots` -> `skillExistsInRoot`; `readWorkspaceSkillVersion` and `findSkillMarkdown` take a single root. The single-root note lives above the return. - Removed comments whose intent is already conveyed by the function/name. - Updated tests to the single-root signatures and added no-root cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Matthew Fisher (MicroFish91)
marked this pull request as ready for review
August 7, 2026 00:50
Contributor
Author
|
Nathan (@nturinski) I think you mentioned a new deploy skill in this flow that needs to be added, we should add that version to the telemetry list as well once we update that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.