Skip to content

Deployment plan view fixes - #1627

Open
Megan Mott (motm32) wants to merge 4 commits into
feat/CoRfrom
meganmott/average-kingfisher
Open

Deployment plan view fixes #1627
Megan Mott (motm32) wants to merge 4 commits into
feat/CoRfrom
meganmott/average-kingfisher

Conversation

@motm32

Copy link
Copy Markdown
Contributor

Fixes: #1622

I also noticed the subscription and location had not been properly being shown on the view even if they have been chosen in the chat and show up in the plan.md. I tested this and it seemed to fix it.

@motm32
Megan Mott (motm32) requested a review from a team as a code owner July 29, 2026 20:47
import { ext } from "../../../extensionVariables";
import { CopilotOnRailsContext } from "../../../utils/copilotOnRails/CopilotOnRailsContext";
import { DEPLOYMENT_PLAN_FILE_GLOB } from "../../../tree/project/projectPlanFiles";
import { CopilotOnRailsContext } from "../../../utils/copilotOnRails/CopilotOnRailsContext";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this got moved? I don't see any obvious difference

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just formatting differences I'll move it back

{ name: 'East US 2', code: 'eastus2' },
{ name: 'West US', code: 'westus' },
{ name: 'West US 2', code: 'westus2' },
{ name: 'West US 3', code: 'westus3' },

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it's been like this for a while, but I feel like we should get this static list from the locations step or something similar in the tools package rather than managing it

@MicroFish91 Matthew Fisher (MicroFish91) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also wrap with corId('deploymentPlan.getLocations')

@motm32

Copy link
Copy Markdown
Contributor Author

Making more changes so waiting to get those into this PR before merging

@motm32

Copy link
Copy Markdown
Contributor Author

The above changes include some updates to the view to better align with what the azure-prepare skill flow looks like. I also removed the already approved plan functionality as it was super buggy since the status could be different with each iteration which made it so users could not continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants