Improve VS Code extension LSP lifecycle error handling#10756
Open
RodgeFu wants to merge 2 commits into
Open
Conversation
RodgeFu
requested review from
AlitzelMendez,
bterlson,
chrisradek,
lirenhe,
markcowl,
timotheeguerin and
witemple-msft
as code owners
microsoft-github-policy-service
Bot
added
the
ide
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
| await oldClient?.stop(); | ||
| // Use dispose() instead of stop() to ensure proper cleanup even when the old client | ||
| // is in StartFailed state. stop() skips cleanup when needsStop() returns false | ||
| // (e.g. after a failed start), which can leave commands like 'typespec.applyCodeFix' |
Member
There was a problem hiding this comment.
this feels like a bug in the extension system of vscode? Do they have an issue for that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve VS Code extension error handling based on telemetry from current compiler usage.
Summary: