Skip to content

[test-improver] test: add edge case tests for NonNullableReferenceNotInitializedSuppressor #8837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
Jun 5, 2026
Merged

[test-improver] test: add edge case tests for NonNullableReferenceNotInitializedSuppressor #8837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions ...UnitTests/MSTest.Analyzers.UnitTests/NonNullableReferenceNotInitializedSuppressorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,77 @@ public class SomeClass
await VerifySingleSuppressionAsync(code, isSuppressed: true);
}

[TestMethod]
public async Task TestContextPropertyOnClassWithDerivedTestClassAttribute_DiagnosticIsSuppressed()
{
Comment thread
Evangelink marked this conversation as resolved.
string code = @"
#nullable enable

using System;
using Microsoft.VisualStudio.TestTools.UnitTesting;

[AttributeUsage(AttributeTargets.Class)]
public class DerivedTestClassAttribute : TestClassAttribute { }

[DerivedTestClass]
public class SomeClass
{
public TestContext {|#0:TestContext|} { get; set; }
}
";

await VerifySingleSuppressionAsync(code, isSuppressed: true);
}

[TestMethod]
public async Task TestContextPropertyWithWrongTypeName_DiagnosticIsNotSuppressed()
Comment thread
Evangelink marked this conversation as resolved.
{
string code = @"
#nullable enable

using Microsoft.VisualStudio.TestTools.UnitTesting;

public class MyCustomContext { }

[TestClass]
public class SomeClass
{
public MyCustomContext {|#0:TestContext|} { get; set; }
}
Comment thread
Evangelink marked this conversation as resolved.
";

await VerifySingleSuppressionAsync(code, isSuppressed: false);
}

[TestMethod]
public async Task TestContextPropertyWithWrongPropertyName_DiagnosticIsNotSuppressed()
{
string code = @"
#nullable enable

using Microsoft.VisualStudio.TestTools.UnitTesting;

[TestClass]
public class SomeClass
{
public TestContext {|#0:MyContext|} { get; set; }
}
";

var test = new VerifyCS.Test
{
TestCode = code,
};

test.ExpectedDiagnostics.Add(DiagnosticResult.CompilerError("CS8618")
.WithLocation(0)
.WithOptions(DiagnosticOptions.IgnoreAdditionalLocations)
.WithArguments("property", "MyContext")
.WithIsSuppressed(false));

await test.RunAsync();
}

private Task VerifySingleSuppressionAsync(string source, bool isSuppressed)
=> VerifyDiagnosticsAsync(source, [(0, isSuppressed)]);

Expand Down