Repository navigation
M kovalsky/1328 fix - #1341
Open
Michael Kovalsky (m-kovalsky) wants to merge 2 commits into
Open
M kovalsky/1328 fix#1341Michael Kovalsky (m-kovalsky) wants to merge 2 commits into
Michael Kovalsky (m-kovalsky) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Michael Kovalsky (m-kovalsky)
October 11, 2026 08:51
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The hostname decoder selects the tenant segment instead of the workspace segment, leaving cross-workspace service-principal resolution broken.
1 open finding
What changed in this PR
Improves Direct Lake source resolution for service-principal authentication and reorganizes launcher tools.
Changes:
- Uses public Fabric APIs before internal metadata APIs.
- Decodes workspace IDs from SQL endpoint hosts.
- Reorders launcher entries.
| File | Description |
|---|---|
src/sempy_labs/tom/_model.py |
Adds Direct Lake source resolution logic. |
src/sempy_labs/_app.py |
Reorders the interactive tool catalog. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+6141
to
+6143
| prefix = server.split(".")[0].split("-")[0].upper() | ||
| if len(prefix) < 26: | ||
| return [] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.