Repository navigation
M kovalsky/policysets - #1340
Michael Kovalsky (m-kovalsky) wants to merge 8 commits into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Policy Set deletion uses an unsupported generic endpoint, and several public functions lack required return annotations.
2 open findings
What changed in this PR
Adds Policy Set REST API support and reorganizes application launcher ordering.
Changes:
- Adds listing, deletion, activation, deactivation, and active-policy lookup APIs.
- Exports the new Policy Set functions.
- Reorders launcher tools.
| File | Description |
|---|---|
policy_set/_items.py |
Adds Policy Set list and delete wrappers. |
policy_set/_activate.py |
Adds activation and capacity lookup wrappers. |
policy_set/__init__.py |
Exports Policy Set APIs. |
_app.py |
Reorders launcher entries. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| capacity: str | UUID, | ||
| allow_replace: bool = False, | ||
| workspace: Optional[str | UUID] = None, | ||
| ): |
|
|
||
|
|
||
| @log | ||
| def delete_policy_set(policy_set: str | UUID, workspace: Optional[str | UUID] = None): |
| else: | ||
| # Attempt to get the resource group | ||
| try: | ||
| dfRG = get_resource_group( |
There was a problem hiding this comment.
[Generated by Long's Agent] [HIGH RISK]
The move left list_resource_groups, get_resource_group and create_or_update_resource_group undefined here. Every authenticated creation now raises NameError: an explicit group fails at get_resource_group, then at the create helper in except; None fails at list_resource_groups. The legacy public API forwards here too. Import or move these helpers and cover both branches. Previous implementation.
No description provided.