Repository navigation
M kovalsky/app upgrade - #1339
Open
Michael Kovalsky (m-kovalsky) wants to merge 11 commits into
Open
Michael Kovalsky (m-kovalsky) wants to merge 11 commits into
Michael Kovalsky (m-kovalsky) wants to merge 11 commits into
Conversation
Copilot started reviewing on behalf of
Michael Kovalsky (m-kovalsky)
October 11, 2026 07:35
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Recursive deletion accepts unvalidated client-controlled paths, with additional correctness and accessibility issues remaining.
7 open findings
What changed in this PR
Upgrades the interactive app, adds Lakehouse Manager, and expands semantic-model lineage across workspaces.
Changes:
- Adds lakehouse browsing, recovery, deletion, and maintenance UI.
- Enhances launcher guidance and environment-aware tool availability.
- Uses Fabric relation APIs for cross-workspace report discovery.
| File | Description |
|---|---|
tests/test_lakehouse.py |
Tests empty and incomplete blob responses. |
tests/test_lakehouse_manager.py |
Tests Lakehouse Manager behavior and UI. |
tests/test_app.py |
Tests launcher guidance and availability. |
src/sempy_labs/semantic_model/_lineage_view.py |
Adds cross-workspace report lineage. |
src/sempy_labs/semantic_model/_find_unused_objects.py |
Scans reports across workspaces. |
src/sempy_labs/report/_report_list_functions.py |
Uses report and workspace IDs. |
src/sempy_labs/lakehouse/_lakehouse_manager.py |
Implements Lakehouse Manager. |
src/sempy_labs/lakehouse/_blobs.py |
Handles sparse blob responses. |
src/sempy_labs/lakehouse/__init__.py |
Touches lakehouse package exports. |
src/sempy_labs/_utils.py |
Adds item endpoint mappings. |
src/sempy_labs/_ui_components.py |
Adds warehouse and file icons. |
src/sempy_labs/_list_functions.py |
Lists downstream reports across workspaces. |
src/sempy_labs/_helper_functions.py |
Adds relation API wrappers. |
src/sempy_labs/_app.py |
Enhances launcher UI and tool catalog. |
src/sempy_labs/__init__.py |
Exports relation helpers. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| // Selectable: everything the user can act on, so not the two containers. | ||
| function selectable(node) { | ||
| return node.type !== "Container" && node.type !== "More"; |
Comment on lines
+1138
to
+1142
| paths = [str(path).strip("/") for path in (data.get("paths") or [])] | ||
| single = str(data.get("path") or "").strip("/") | ||
| if single and single not in paths: | ||
| paths.append(single) | ||
| return [path for path in paths if path] |
Comment on lines
+1237
to
+1243
| function setGuideOpen(open) { | ||
| modal.classList.toggle("show", open); | ||
| if (open) { | ||
| dialogBody.scrollTop = 0; | ||
| closeGuideBtn.focus(); | ||
| } | ||
| } |
| create_schema, | ||
| ) | ||
|
|
||
|
|
Comment on lines
+135
to
+137
| modified = str(blob.get("Creation Time") or "") | ||
| if modified > record["modified"]: | ||
| record["modified"] = modified |
| direct_ids = { | ||
| str(rel.get("itemId")) | ||
| for rel in relations.get("relations", []) | ||
| if str(rel.get("dependentOnItemId", "")).lower() == ds_id.lower() |
Comment on lines
+91
to
+92
| "DataBuildToolJob": "dataBuildToolJobs", | ||
| "PolicySet": "policySets", |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.