Repository navigation
fix(poetry): pep503 normalize package name - #242
Merged
Don Jayamanne (DonJayamanne) merged 5 commits intoOct 9, 2025
Merged
Don Jayamanne (DonJayamanne) merged 5 commits into
Don Jayamanne (DonJayamanne) merged 5 commits into
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Don Jayamanne (DonJayamanne)
self-requested a review
August 21, 2025 11:10
Contributor
Author
|
Hi there Don Jayamanne (@DonJayamanne)! Any chance you can look at this? |
Don Jayamanne (DonJayamanne)
previously approved these changes
Oct 8, 2025
Matt Bierner (mjbvz)
previously approved these changes
Oct 8, 2025
Victor Colomb (VictorColomb)
dismissed stale reviews from Matt Bierner (mjbvz) and Don Jayamanne (DonJayamanne)
via
October 8, 2025 11:20
9491c07
Victor Colomb (VictorColomb)
requested review from
Don Jayamanne (DonJayamanne) and
Daniel Imms (Tyriar)
October 8, 2025 11:20
Don Jayamanne (DonJayamanne)
approved these changes
Oct 8, 2025
Don Jayamanne (DonJayamanne)
enabled auto-merge (squash)
October 9, 2025 06:53
Sandeep Somavarapu (sandy081)
approved these changes
Oct 9, 2025
Don Jayamanne (DonJayamanne)
dismissed
Daniel Imms (Tyriar)’s stale review
October 9, 2025 08:02
Issues addressed
Don Jayamanne (DonJayamanne)
merged commit Oct 9, 2025
e97b950
into
microsoft:main
36 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When generating the name of the virtualenv, Poetry honors PEP 503 project name normalization 1. In short, the name of the project is lowercased, and all runs of
-_.are replaced with a single-.For example, the normalized name of the following extract of pyproject.toml is
my-project.When a project name is modified like this by Poetry, the virtualenv name generated by this project will not match and the Poetry locator will not pick up any Poetry virtual environments (with the exception of the in-project
.venv).PR Description
This PR ports the few lines of Python code from poetry-core 2 that implement the name normalization to the Poetry locator in order to fix this unaligned behavior.
Footnotes
https://peps.python.org/pep-0503/#normalized-names ↩
https://github.com/python-poetry/poetry-core/blob/a2c068227358984d835c9684de723b046bdcd67a/src/poetry/core/_vendor/packaging/utils.py#L46-L51 ↩