Skip to content

[iPad] Keep toolbox categories re-openable on consecutive taps in Blocks editor#11318

Draft
Copilot wants to merge 3 commits into
masterfrom
copilot/fix-toolbox-category-selection
Draft

[iPad] Keep toolbox categories re-openable on consecutive taps in Blocks editor#11318
Copilot wants to merge 3 commits into
masterfrom
copilot/fix-toolbox-category-selection

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 16, 2026

On iPad/touch devices, tapping the same toolbox category twice in a row could leave the category unusable until another category was selected. This updates toolbox selection behavior so repeated taps on the same category continue to work as expected on touch.

  • Behavior change: category reselection on touch

    • Updated Toolbox.setSelection(...) in webapp/src/toolbox.tsx to avoid the desktop toggle-close path when the current device is touch-enabled.
    • Result: re-tapping an already selected category on iPad/mobile no longer clears selection + closes flyout in a way that blocks immediate reuse.
  • Code hygiene in touched logic

    • Switched the selected-category comparison to strict equality in the same conditional.
if (this.state.selectedItem === id && !force && !onlyTriggerOnClick && !pxt.BrowserUtils.isTouchEnabled()) {
    this.clearSelection();
    this.closeFlyout();
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6001 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-tUAg4a --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,7363283155432224682,7605895856690065294,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
    • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6121 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-bT3QFD --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,16262518828600692227,9097577887794854804,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6001 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-tUAg4a --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,7363283155432224682,7605895856690065294,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
    • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6121 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-bT3QFD --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,16262518828600692227,9097577887794854804,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
  • fonts.googleapis.com
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/pxt/pxt/node_modules/less/bin/lessc theme/style.less built/web/semantic.css --include-path=node_modules/semantic-ui-less:node_modules/pxt-core/theme:theme/foo/bar:theme:node_modules/pxt-core/react-common/styles:react-common/styles:node_modules/@fortawesome:node_modules/pxt-core/node_modules/@fortawesome c/brotli_bit_stream.o lude odules/.bin/as (dns block)
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/pxt/pxt/node_modules/less/bin/lessc theme/style.less built/web/semantic.css --include-path=node_modules/semantic-ui-less:node_modules/pxt-core/theme:theme/foo/bar:theme:node_modules/pxt-core/react-common/styles:react-common/styles:node_modules/@fortawesome:node_modules/pxt-core/node_modules/@fortawesome node-gyp-build 20.2/include/node /usr/local/lib/node_modules/npm/node_modules/@np/home/REDACTED/.cache/node-gyp/20.20.2/deps/openssl/config 20.2/src (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6121 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-bT3QFD --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,16262518828600692227,9097577887794854804,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version (dns block)
    • Triggering command: /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync (dns block)
  • www.makecode.com
    • Triggering command: /usr/local/bin/node node built/pxt.js buildtarget git l/op�� st line and append a colon to th/home/REDACTED/.cache/node-gyp/20.20.2/deps/zlib lude /home/REDACTED/work/pxt/pxt/node_m/home/REDACTED/.cache/node-gyp/20.20.2/deps/v8/include 20.2/src (dns block)
    • Triggering command: /usr/local/bin/node node built/pxt.js buildtarget node 20.2�� " 20.2/include/node k/pxt/pxt/node_modules/ttf2woff2/node_modules/.b/home/REDACTED/.cache/node-gyp/20.20.2/deps/openssgulp 20.2/src (dns block)
    • Triggering command: /usr/local/bin/node node /home/REDACTED/.npm/_npx/49151a050df6c2cd/node_modules/.bin/pxt serve --noBrowser --port 3232 /home/REDACTED/.cache/node-gyp/20.20.2/include/node /bin/sh /home/REDACTED/.cash -I /home/REDACTED/.cagulp lint /bin/sh Rele�� " /home/REDACTED/.cache/node-gyp/20../pxtblocks/ cal/bin/sh /home/REDACTED/.canode -I /home/REDACTED/.cagulp sed (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI and others added 2 commits May 16, 2026 00:36
Copilot AI changed the title [WIP] Fix toolbox category not opening twice in a row [iPad] Keep toolbox categories re-openable on consecutive taps in Blocks editor May 16, 2026
Copilot AI requested a review from srietkerk May 16, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iPad] Beta - Cannot use any toolbox category twice in a row

2 participants