[iPad] Keep toolbox categories re-openable on consecutive taps in Blocks editor#11318
Draft
Copilot wants to merge 3 commits into
Draft
[iPad] Keep toolbox categories re-openable on consecutive taps in Blocks editor#11318Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/microsoft/pxt/sessions/03503b57-7e02-4a06-8765-b7f0563c16ed Co-authored-by: srietkerk <49178322+srietkerk@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/pxt/sessions/03503b57-7e02-4a06-8765-b7f0563c16ed Co-authored-by: srietkerk <49178322+srietkerk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix toolbox category not opening twice in a row
[iPad] Keep toolbox categories re-openable on consecutive taps in Blocks editor
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iPad/touch devices, tapping the same toolbox category twice in a row could leave the category unusable until another category was selected. This updates toolbox selection behavior so repeated taps on the same category continue to work as expected on touch.
Behavior change: category reselection on touch
Toolbox.setSelection(...)inwebapp/src/toolbox.tsxto avoid the desktop toggle-close path when the current device is touch-enabled.Code hygiene in touched logic
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
accounts.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6001 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-tUAg4a --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,7363283155432224682,7605895856690065294,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6121 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-bT3QFD --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,16262518828600692227,9097577887794854804,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version(dns block)clients2.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6001 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-tUAg4a --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,7363283155432224682,7605895856690065294,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync(dns block)/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6121 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-bT3QFD --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,16262518828600692227,9097577887794854804,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version(dns block)fonts.googleapis.com/usr/local/bin/node node /home/REDACTED/work/pxt/pxt/node_modules/less/bin/lessc theme/style.less built/web/semantic.css --include-path=node_modules/semantic-ui-less:node_modules/pxt-core/theme:theme/foo/bar:theme:node_modules/pxt-core/react-common/styles:react-common/styles:node_modules/@fortawesome:node_modules/pxt-core/node_modules/@fortawesome c/brotli_bit_stream.o lude odules/.bin/as(dns block)/usr/local/bin/node node /home/REDACTED/work/pxt/pxt/node_modules/less/bin/lessc theme/style.less built/web/semantic.css --include-path=node_modules/semantic-ui-less:node_modules/pxt-core/theme:theme/foo/bar:theme:node_modules/pxt-core/react-common/styles:react-common/styles:node_modules/@fortawesome:node_modules/pxt-core/node_modules/@fortawesome node-gyp-build 20.2/include/node /usr/local/lib/node_modules/npm/node_modules/@np/home/REDACTED/.cache/node-gyp/20.20.2/deps/openssl/config 20.2/src(dns block)www.google.com/proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --mute-audio --string-annotations --crashpad-handler-pid=6121 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/puppeteer_dev_chrome_profile-bT3QFD --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,16262518828600692227,9097577887794854804,262144 --enable-features=PdfOopif --disable-features=AcceptCHFrame,IsolateSandboxedIframes,MediaRouter,OptimizationHints,PaintHolding,ProcessPerSiteUpToMainFrameThreshold,Translate --variations-seed-version(dns block)/home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome /home/REDACTED/.cache/puppeteer/chrome/linux-131.0.6778.204/chrome-linux64/chrome --allow-pre-commit-input --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-crash-reporter --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-hang-monitor --disable-infobars --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-REDACTEDing --disable-search-engine-choice-screen --disable-sync(dns block)www.makecode.com/usr/local/bin/node node built/pxt.js buildtarget git l/op�� st line and append a colon to th/home/REDACTED/.cache/node-gyp/20.20.2/deps/zlib lude /home/REDACTED/work/pxt/pxt/node_m/home/REDACTED/.cache/node-gyp/20.20.2/deps/v8/include 20.2/src(dns block)/usr/local/bin/node node built/pxt.js buildtarget node 20.2�� " 20.2/include/node k/pxt/pxt/node_modules/ttf2woff2/node_modules/.b/home/REDACTED/.cache/node-gyp/20.20.2/deps/openssgulp 20.2/src(dns block)/usr/local/bin/node node /home/REDACTED/.npm/_npx/49151a050df6c2cd/node_modules/.bin/pxt serve --noBrowser --port 3232 /home/REDACTED/.cache/node-gyp/20.20.2/include/node /bin/sh /home/REDACTED/.cash -I /home/REDACTED/.cagulp lint /bin/sh Rele�� " /home/REDACTED/.cache/node-gyp/20../pxtblocks/ cal/bin/sh /home/REDACTED/.canode -I /home/REDACTED/.cagulp sed(dns block)If you need me to access, download, or install something from one of these locations, you can either: