Repository navigation
[code-documentation] Correct benchmark gate thresholds - #400
Merged
Pedro Henrique Penna (ppenna) merged 1 commit intoOct 7, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
October 5, 2026 22:51
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation now accurately reflects the implemented defaults and regression logic.
Review effort: Balanced
Findings: None
What changed in this PR
Updates benchmark regression-gate documentation to match current CLI defaults and implementation.
Changes:
- Corrects the relative regression threshold from 50% to 40%.
- Corrects latency tolerance from 10 ms to 5 ms.
| File | Description |
|---|---|
doc/benchmarks.md |
Aligns documented gate thresholds with implementation and usage documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pedro Henrique Penna (ppenna)
marked this pull request as ready for review
October 6, 2026 06:10
Pedro Henrique Penna (ppenna)
deleted the
code-documentation/benchmark-gate-thresholds-37382439709-5993f30a435046a1
branch
October 7, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the stale performance-gate thresholds in
doc/benchmarks.md:The current source of truth in
scripts/nvx_tools/performance.py:2002-2011sets the defaults to a 40% threshold and a 5 ms absolute tolerance.python3 scripts/nvx.py performance gate --helpconfirms the command surface. The existingdoc/usage.mdsection also documents the current 40% and 5 ms values.This is a single documentation mismatch. I reviewed recent documentation workflow outcomes and active pull-request file lists; no active or prior proposal covers these benchmark-gate threshold statements. The checked paths are
doc/benchmarks.md,scripts/nvx_tools/performance.py,doc/usage.md, and theperformance gate --helpcommand.Scope and validation
doc/benchmarks.mdpython3 scripts/nvx.py performance gate --help— passedpython3 -m unittest scripts/test_performance.py -q— passed (53 tests)git diff --check— passedgit diff --numstat/git diff --raw— one allowed Markdown file; no gitlink changeNo dependency, public API/CLI/ABI, gitlink, or OpenVMM change was made; no executable code was modified.