Repository navigation
[Seatbelt] Explicitly denied path no longer leaks metadata - #1439
Open
Elliot (theelliotm) wants to merge 1 commit into
Open
Elliot (theelliotm) wants to merge 1 commit into
Elliot (theelliotm) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The macOS behavioral regression test must be landed in-tree with this security fix.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes Seatbelt metadata leakage for explicitly denied paths.
Changes:
- Explicitly denies
file-read-metadata. - Updates unit coverage and backend documentation.
| File | Description |
|---|---|
profile_builder.rs |
Strengthens denied-path profile generation. |
seatbelt-backend.md |
Documents metadata-rule precedence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📖 Description
Seatbelt's baseline includes
file-read-metadataaccess for all files, but when a path is explicitly denied, thedeny file-read*rule is considered "less-specific", so it doesn't override the allow-all metadata grant. This PR now explicitly denies metadata access for files indeniedPathsand documents this.🔗 References
Resolves #1430
🔍 Validation
Tested in CI, all MacOS tests green (using tests in #1431): https://github.com/microsoft/mxc/actions/runs/37581840096
✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see pull request builds)📋 Issue Type
Microsoft Reviewers: Open in CodeFlow