Repository navigation
AI: Strengthen Perf Police investigation and evidence guidance - #835
Jahnvi Thakkar (jahnvi480) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
PR Performance Report✅ No regression detectedNo consistent slowdowns detected across all 2 environments. 0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS Coverage: 2 of 2 environments completed. Advisory result; does not block merging. Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsUnix / SQL Server 2022
Unix / SQL Server 2025
Build and measurement detailsPR head:
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only changes are consistent, scoped, and contain no identified blocking issues.
0 open findings
What changed in this PR
Strengthens Perf Police guidance with evidence-led review, profiling, and handoff practices.
Changes:
- Adds a falsifiable, baseline-driven performance review workflow.
- Expands profiling provenance, workload, Release-build, and statistical guidance.
- Clarifies the Perf Police agent’s review-only role and implementation handoff.
| File | Description |
|---|---|
.github/skills/performance-code-review/SKILL.md |
Expands performance review and evidence requirements. |
.github/skills/mssql-profiler/SKILL.md |
Strengthens profiling execution and reporting guidance. |
.github/agents/perf-police.agent.md |
Clarifies workflow use and coding-session handoff. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 62.6%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.connection.connection_pool.cpp: 82.3%
mssql_python.pybind.connection.connection.cpp: 83.1%
mssql_python.logging.py: 86.2%
mssql_python.pooling.py: 90.1%
mssql_python.pybind.fetch_temporal.hpp: 92.1%
mssql_python.cursor.py: 92.5%🔗 Quick Links
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only changes are consistent, actionable, and have valid local links and anchors.
0 open findings
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
| For single-configuration CMake generators, `--config Release` alone does not | ||
| select an optimized build; inspect `CMAKE_BUILD_TYPE` and the effective compile | ||
| commands. Verify optimization, assertion, and profiling flags on every measured | ||
| arm, including archived baselines. Retain that evidence rather than accepting | ||
| or rejecting a build solely from its command label. |
Work Item / Issue Reference
Summary
Strengthen the reusable Perf Police agent and performance-review/profiling skills with a generic, evidence-led investigation method rather than PR-specific case studies.
Changes are limited to three agent/skill Markdown files. No driver, benchmark, pipeline, workload, or threshold implementation changes are included.
Validation:
git diff --checkpassed. Frontmatter, relative links/anchors, ASCII text, and code fences were checked. Native builds and SQL tests were not run because this is a documentation-only change.