fix: handle COMError in wait_enabled when UI element becomes stale#324
Open
nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
Open
fix: handle COMError in wait_enabled when UI element becomes stale#324nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
nuthalapativarun wants to merge 1 commit intomicrosoft:pre-releasefrom
Conversation
Selecting an option from a dropdown (or any interaction that triggers a UI change) can invalidate the underlying COM element. The subsequent call to control.is_enabled() then raises: _ctypes.COMError: (-2147220991, 'An event was unable to invoke any of the subscribers', ...) Wrap the is_enabled() poll in a try/except so that a stale-element COM error is treated as "ready" (with a warning) rather than crashing the agent loop. Closes microsoft#246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selecting an item from a dropdown (or any interaction that triggers a UI state change) can invalidate the underlying COM automation element. The subsequent
is_enabled()poll inwait_enabled()then raises aCOMErrorand crashes the agent loop:Traceback from the issue:
Changes
is_enabled()call inwait_enabled()inside atry/except Exceptionblock inufo/automator/ui_control/controller.pyCOMError), logs a warning and breaks out of the wait loop, treating the element as readyTesting
Reproduced by selecting an option from a dropdown menu in an application that triggers a UI rebuild. The fix allows the agent to continue execution after dropdown selection instead of crashing.
Closes #246