Skip to content

FIX isolate TAP configuration and per-run state - #2338

Open
Roman Lutz (romanlutz) wants to merge 4 commits into
microsoft:mainfrom
romanlutz:romanlutz-tree-attack-configuration
Open

FIX isolate TAP configuration and per-run state#2338
Roman Lutz (romanlutz) wants to merge 4 commits into
microsoft:mainfrom
romanlutz:romanlutz-tree-attack-configuration

Conversation

@romanlutz

Copy link
Copy Markdown
Contributor

Description

TreeOfAttacksWithPruningAttack stored its visualization root on the reusable attack instance, so concurrent executions with different prepended conversation depths could attach first-level nodes to the wrong parent.

This change moves the visualization root into TAPAttackContext and consolidates six stable tree-search settings into a private frozen configuration object. The existing keyword-only constructor remains the compatibility layer, preserving its parameter names, defaults, validation messages, factory reflection, PAIR behavior, identifiers, and persistence/resume contracts. No public configuration API or migration is introduced.

Tests and Documentation

  • Added coverage for default and custom configuration, exact validation behavior, immutability, legacy constructor compatibility, PAIR's pinned settings, and deterministic interleaved execution contexts.
  • Ran 118 focused TAP/PAIR tests and 153 factory, registry, parameter-consistency, Foundry, and schema-forwarding tests.
  • Ran Ruff check, Ruff format check, and focused ty check on the changed files.
  • Documentation was not changed because the public API and behavior remain compatible.
  • JupyText was not applicable.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 92dc0f48-0fb4-4cbd-866c-ce5f41796439
@varunj-msft varunj-msft self-assigned this Aug 6, 2026
@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 7, 2026
@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 7, 2026
@romanlutz
Roman Lutz (romanlutz) added this pull request to the merge queue Aug 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 7, 2026
Roman Lutz (romanlutz) and others added 3 commits August 6, 2026 19:19
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants