Refactor time-off reason mapping in Workday Request Time Off topic#488
Open
srideshpande wants to merge 1 commit intouser/srdeshpande/Workday-MultiDay-Leave-Submit-Issuesfrom
Conversation
Contributor
|
@srideshpande please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor time-off reason mapping in Workday Request Time Off topic
Restructures how the Workday
ReasonIDis resolved when submitting multi-day time-off requests, decoupling the user-facing reason choice from the Workday-specific reason identifier.Changes
Title-based reason config withReasonKey-based lookup: TheTimeOffReasonConfigtable now uses a genericReasonKey(full_day,half_day_am,half_day_pm) instead of combined title strings, making the mapping cleaner and easier to maintain.ReasonKey+TimeOffTypeID→ReasonIDresolution step: A newSetVariablenode (resolve_reason_id→Topic.resolvedReasonID) performs aLookUpto map the user's selected reason + time-off type to the correct WorkdayReasonIDbefore submission.ReasonID: The multi-day time-off submission now passesTopic.resolvedReasonIDinstead of the rawTopic.timeOffReason.Switch()to display a friendly label instead of a config table lookup.How to Test
topic.yamlfrom this PR and paste it into the MultiDay_MG_Leave topic in the Fast Track Demo Env environment in preview.ReasonIDis resolved and passed to the plugin.Before
After
Successful call made with the mapped reason ids:
