Skip to content

fix(mirror): forward taps to MUI devices without a touch panel #7880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesarich merged 1 commit into from
Nov 2, 2026
Merged

fix(mirror): forward taps to MUI devices without a touch panel #7880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/DisplayMirror.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ import androidx.compose.ui.unit.dp
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import org.jetbrains.compose.resources.stringResource
import org.koin.compose.viewmodel.koinViewModel
import org.meshtastic.core.repository.MirrorFormat
import org.meshtastic.core.repository.MirrorFrame
import org.meshtastic.core.repository.MirrorPalette
import org.meshtastic.core.resources.Res
Expand Down Expand Up @@ -185,7 +186,8 @@ fun DisplayMirrorContent(modifier: Modifier = Modifier, viewModel: DisplayMirror
currentFrame,
palette,
enabled = active,
hasTouch = displayInfo?.has_touch == true,
// MUI (the only RGB565 source) feeds taps to its own virtual pointer, touch panel or not
hasTouch = displayInfo?.has_touch == true || currentFrame.format == MirrorFormat.RGB565,
onEvent = viewModel::sendKey,
onTouch = viewModel::sendTouch,
onChar = viewModel::sendChar,
Expand Down