Repository navigation
feat(debug): live device screen mirror with remote control (protobufs #1054) - #6987
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait...
 |
| Layer / File(s) | Summary |
|---|---|
Mirror contracts and device controls core/repository/.../DisplayMirrorManager.kt, core/repository/.../AdminController.kt, core/service/.../AdminControllerImpl.kt, core/testing/.../FakeRadioController.kt |
Adds frame and palette models and manager contracts. Adds immediate local-node operations to enable mirroring, request a frame, and send input events. |
Packet routing and chunk reassembly core/data/.../DisplayMirrorManagerImpl.kt, core/data/.../MirrorRectCompositor.kt, core/data/.../FromRadioPacketHandlerImpl.kt, core/data/src/commonTest/.../manager/*Test.kt |
Routes display packets from active sessions. Assembles monochrome frames and palettes, composes RGB565 rectangles, and tests chunk validation, routing, and reset behavior. |
Mirror state, rendering, and input feature/settings/.../debugging/*, feature/settings/.../radio/RadioConfig.kt, feature/settings/src/commonTest/.../debugging/*, core/resources/..., core/ui/.../Navigation.kt, .skills/compose-ui/strings-index.txt |
Adds mirror state and controls, frame rendering, input handling, and the Mirror Debug tab. Adds related strings, arrow icons, and tests for input mapping and color resolution. |
Priority:
Merge Risk: 
6d690
-
Mirroring can briefly show inconsistent or stale state when a reset overlaps an incoming frame. The remaining risk is bounded, but synchronizing reset and packet handling is advisable.
Pre-merge checks: 
-
Check name Status Explanation Resolution Tests Prove The Path, Not The End State The standing failure remains unresolved. DisplayMirrorManagerImplTeststill has end-state-only assertions:single-chunk frame completes immediatelychecks only pixel count (lines 85-90); the two-c…Strengthen the affected tests. Assert exact frame bytes and metadata for the single-chunk frame. Use distinct palette regions and compare the complete ordered region list, including coordinates and colors. Assert RGB565 bytes at expected re… Regression Coverage For Changed Behavior Regression coverage remains incomplete for changed behavior. The diff adds only four test files: manager/radio routing tests, input helper tests, and color-helper tests. The following gaps remain: - `… Add focused AdminControllerImplprotobuf/destination tests;DisplayMirrorViewModelfake-flow lifecycle and managed-mode tests; valid multi-chunk RGB565 pixel and canvas-preservation tests; remaining malformed frame/palette boundary and …Moved Code Diffed Against Its Original The visibility widening remains. Commit 4247323 moved private MirrorFrameImagefromDisplayMirror.kttointernalMirrorFrameRenderer.kt:60. Commit e31e2d1 moved private input helpers and con…Preserve the original private scope. Keep MirrorFrameImageand utility helpers in their caller file, or add private wrappers and test through the caller. KeepMirrorRectCompositorprivate or nested insideDisplayMirrorManagerImpl. If …-
Check name Status Explanation Title check The title clearly identifies the main change: a live device screen mirror with remote control in the debug panel. The protobufs reference is relevant supporting context. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Sibling Call Sites And Presence Semantics PASS. The diff does not change ambient temperature, humidity, RSSI, SNR, current, voltage, or particulate-field presence semantics. It adds nullable mirror state and nullable DisplayInfo; all `displ…Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Full details: Sibling Call Sites And Presence Semantics
-
Explanation
PASS. The diff does not change ambient temperature, humidity, RSSI, SNR, current, voltage, or particulate-field presence semantics. It adds nullable mirror state and nullable
DisplayInfo; alldisplayInfoconsumers are in the new mirror UI and use null-safe checks. The only zero defaults are mirror protocol state, palette colors, and input coordinates, not physical measurement fields covered by this check.
-
Full details: Tests Prove The Path, Not The End State
-
Explanation
The standing failure remains unresolved.
DisplayMirrorManagerImplTeststill has end-state-only assertions:single-chunk frame completes immediatelychecks only pixel count (lines 85-90); the two-chunk palette test uses the same region twice and checks onlyregions.size(lines 154-188); RGB565 composition checks only format and canvas size, not pixel placement or untouched bytes (lines 284-291); and the surplus-palette test checks only collection size with identical regions (lines 342-359). The reset test seeds only completed mono and palette values, so it does not prove that incomplete mono, palette, or RGB565 state was cleared (lines 217-225). These tests could pass with incorrect bytes, region contents, or retained partial state.Resolution
Strengthen the affected tests. Assert exact frame bytes and metadata for the single-chunk frame. Use distinct palette regions and compare the complete ordered region list, including coordinates and colors. Assert RGB565 bytes at expected rectangle coordinates and untouched canvas bytes. Assert the surplus-palette case against the exact published region list. For reset, seed incomplete mono, palette, and RGB565 rectangle sequences, call
reset(), and verify that continuations do not complete until fresh offset-zero sequences begin.
Full details: Regression Coverage For Changed Behavior
-
Explanation
Regression coverage remains incomplete for changed behavior. The diff adds only four test files: manager/radio routing tests, input helper tests, and color-helper tests. The following gaps remain: -
AdminControllerImpl.setDisplayMirror,requestDisplayFrame, andsendInputEvent(core/service/.../AdminControllerImpl.kt:147-171) have no implementation tests. A wrong local destination, protobuf field, input default, orsendAdminImmediatecall can reach the radio. Add tests that capture the exact destination, protobuf, and direct-send call for all three methods. -DisplayMirrorViewModellifecycle and managed-mode paths (feature/settings/.../DisplayMirrorViewModel.kt:74-125) have no tests. Disconnect, initialization reset, managed-mode transitions, blocked operations, allowed disable,stopMirroring, andonClearedremain unverified. Use fake flows and collaborators and assert reset calls, state changes, and forwarded arguments. -MirrorRectCompositorhas only a one-chunk test that checks frame size (DisplayMirrorManagerImplTest.kt:284-291). The changed-panel rejection is tested, but valid multi-chunk pixel content, dirty-rectangle placement, and preservation of earlier canvas pixels are not tested. -DisplayMirrorManagerImplstill lacks boundary tests for negative and overflowing frame offsets, changed palette signatures, negative or inconsistent palette totals, and invalid palette region offsets. The reset test uses completed inputs (DisplayMirrorManagerImplTest.kt:217-225), so it does not prove that reset clears an in-progress mono frame, palette, or RGB565 rectangle. -MirrorFrameRendererrendering paths (feature/settings/.../MirrorFrameRenderer.kt:140-223) have no pixel-level tests.MirrorColorResolverTesttests RGB565 conversion and a standalone region helper only. It does not test MONO_VLSB bit order, palette signature matching and fallback, region Y bounds, or little-endian RGB565 pixel reads. -DisplayMirror.ktandDpadRing.kthandlers (DisplayMirror.kt:259-369,DpadRing.kt:158-267) have no interaction tests. Touch scaling and clamping, swipe threshold and dominant-axis selection, Enter/Backspace/Tab forwarding, disabled controls, wedge boundaries, repeat timing, and select long-press behavior remain unverified. Add Compose tests with a test clock or extract the handlers for unit tests. -DebugScreenMirror-tab entry and exit (Debug.kt:178-203,DisplayMirror.kt:133-134) have no test. Selecting the Mirror tab, preserving the existing tabs, and disposing the Mirror content to callstopMirroringremain unverified.Resolution
Add focused
AdminControllerImplprotobuf/destination tests;DisplayMirrorViewModelfake-flow lifecycle and managed-mode tests; valid multi-chunk RGB565 pixel and canvas-preservation tests; remaining malformed frame/palette boundary and partial-reset tests; renderer pixel tests; Compose or extracted-handler interaction tests; and DebugScreen tab-entry/exit lifecycle coverage.
Full details: Moved Code Diffed Against Its Original
-
Explanation
The visibility widening remains. Commit 4247323 moved private
MirrorFrameImagefromDisplayMirror.kttointernalMirrorFrameRenderer.kt:60. Commit e31e2d1 moved private input helpers and constants intointernaldeclarations inDisplayMirrorUtils.kt:29-66,92; current callers and tests use these module-visible declarations. Commit 2323fee extracted private rectangle state intointernal class MirrorRectCompositor; itshandle,snapshot,reset,width, andheightremain module-visible. No later commit restores the original file-private scope.Resolution
Preserve the original private scope. Keep
MirrorFrameImageand utility helpers in their caller file, or add private wrappers and test through the caller. KeepMirrorRectCompositorprivate or nested insideDisplayMirrorManagerImpl. If module-internal visibility is required for tests or reuse, document and intentionally approve that API-scope change instead of treating it as a mechanical move.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Cross-platform feature spec (client-agnostic wire contract, reassembly rules, input mapping, UX and device requirements): meshtastic/design#142 |
|
c9d6548 to
af3e1bc
Compare
aaebc09 to
9f02827
Compare
c5f093f to
f925259
Compare
f925259 to
14b2f58
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: meshtastic/Meshtastic-Android/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
7cca8cc2-c670-41d2-9530-2371a6f445bb
📒 Files selected for processing: 25
.skills/compose-ui/strings-index.txtcore/data/src/commonMain/kotlin/org/meshtastic/core/data/manager/DisplayMirrorManagerImpl.ktcore/data/src/commonMain/kotlin/org/meshtastic/core/data/manager/FromRadioPacketHandlerImpl.ktcore/data/src/commonMain/kotlin/org/meshtastic/core/data/manager/MirrorRectCompositor.ktcore/data/src/commonTest/kotlin/org/meshtastic/core/data/manager/DisplayMirrorManagerImplTest.ktcore/data/src/commonTest/kotlin/org/meshtastic/core/data/manager/FromRadioPacketHandlerImplTest.ktcore/repository/src/commonMain/kotlin/org/meshtastic/core/repository/AdminController.ktcore/repository/src/commonMain/kotlin/org/meshtastic/core/repository/DisplayMirrorManager.ktcore/resources/src/commonMain/composeResources/drawable/ic_keyboard_arrow_left.xmlcore/resources/src/commonMain/composeResources/drawable/ic_keyboard_arrow_right.xmlcore/resources/src/commonMain/composeResources/values/strings.xmlcore/service/src/commonMain/kotlin/org/meshtastic/core/service/AdminControllerImpl.ktcore/testing/src/commonMain/kotlin/org/meshtastic/core/testing/FakeRadioController.ktcore/ui/src/commonMain/kotlin/org/meshtastic/core/ui/icon/Navigation.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/Debug.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/DisplayMirror.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/DisplayMirrorUtils.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/DisplayMirrorViewModel.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/DpadRing.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/MirrorFrameRenderer.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/radio/RadioConfig.ktfeature/settings/src/commonTest/kotlin/org/meshtastic/feature/settings/debugging/DisplayMirrorInputTest.ktfeature/settings/src/commonTest/kotlin/org/meshtastic/feature/settings/debugging/MirrorColorResolverTest.ktgradle.propertiesgradle/libs.versions.toml
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
3ac8723 to
9756d79
Compare
9756d79 to
71b6d91
Compare
protobufs
|
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: meshtastic/Meshtastic-Android
- Branch: screen-mirror-poc
- File: .coderabbit.yaml
- Commit: 71b6d91
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
6f95251c-550b-4d8f-8d59-6ed85d305dbe
-
.skills/compose-ui/strings-index.txtcore/data/src/commonMain/kotlin/org/meshtastic/core/data/manager/DisplayMirrorManagerImpl.ktcore/data/src/commonTest/kotlin/org/meshtastic/core/data/manager/DisplayMirrorManagerImplTest.ktcore/resources/src/commonMain/composeResources/values/strings.xmlcore/service/src/commonMain/kotlin/org/meshtastic/core/service/AdminControllerImpl.ktcore/testing/src/commonMain/kotlin/org/meshtastic/core/testing/FakeRadioController.ktfeature/settings/src/commonMain/kotlin/org/meshtastic/feature/settings/debugging/DisplayMirror.ktgradle/libs.versions.toml
-
- .skills/compose-ui/strings-index.txt
- core/resources/src/commonMain/composeResources/values/strings.xml
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
-
71b6d91 to
6d690aa
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
-
-
- Source mode: Auto
- Repository: meshtastic/Meshtastic-Android
- Branch: screen-mirror-poc
- File: .coderabbit.yaml
- Commit: 6d690aa
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
dbd6ba89-c785-4597-8ee4-3eec337befe1
-
core/data/src/commonMain/kotlin/org/meshtastic/core/data/manager/DisplayMirrorManagerImpl.ktcore/data/src/commonTest/kotlin/org/meshtastic/core/data/manager/DisplayMirrorManagerImplTest.kt
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
-
Consumes the DisplayFrame PoC protobufs (2.99.0-screen-mirror-poc-SNAPSHOT from mavenLocal, useMavenLocal committed on this branch): DisplayMirrorManager reassembles FromRadio.display_frame chunks into MirrorFrame snapshots, AdminController gains setDisplayMirror + sendInputEvent, and the Debug panel gains a Mirror tab rendering the device's 1bpp framebuffer live with a D-pad driving the firmware InputBroker. PoC: tab strings deliberately unlocalized.
Cap the mirror canvas at 512.dp (4x for a 128px OLED) instead of filling the window width, fold the frame info into the toggle row, and pair Down/Back so the controls fit without scrolling on desktop.
Manager: validate format (MONO_VLSB only) and geometry (width/height must describe exactly total_size bytes) so malformed device input can't reach aspectRatio and crash; unit tests for reassembly, drops, restarts. AdminController: setDisplayMirror/sendInputEvent become non-suspend immediate sends (teardown-safe, input never queues behind bulk admin) and gain requestDisplayFrame. Mirror tab: render each frame once into a 1:1 ImageBitmap scaled with FilterQuality.None (kills the fractional-scale seams), gate controls on connection state, reset the toggle on disconnect, stop the stream on tab dispose and ViewModel clear, add a one-shot Refresh, inject AdminController/ConnectionStateProvider instead of RadioController. Dispatch: display_frame test coverage incl. revoked-session.
Populates the new DisplayInfo during the handshake — dimensions from the live display device, MONO_VLSB frame format, PanelClass from the panel defines (EINK/HUB75/TFT/LCD/OLED), has_touch from HAS_TOUCHSCREEN — so clients can gate mirroring UI and adapt to the panel. Absent on display-less builds. Regenerates protos (DisplayInfo, DisplayFrame rect fields reserved for dirty-rect streaming).
Replace the flat button stack with the researched control surface: cross-shaped 5-way cluster (56dp circular keys, 8dp gaps, Material Symbols chevrons with contentDescriptions), directions auto-repeat on hold (500ms then 10Hz — slow enough for the radio to render), OK long-press sends SELECT_LONG, Back sits below per TV-remote convention. The mirror itself becomes an input surface: click to capture the keyboard (arrows / Enter / Esc, with a visible focus ring and hint) and swipe in a cardinal direction to navigate. Consumes the new DeviceMetadata.display: shows an e-ink hint steering toward one-shot Refresh. Adds keyboard_arrow_left/right icons (Material Symbols rounded, transposed from the existing up glyph).
DisplayMirrorManager reassembles FromRadio.display_palette chunks (signature-keyed, defaults captured on the offset-0 chunk) into a MirrorPalette; frames carry palette_signature and the renderer resolves each pixel through the region table (last overlapping region wins, matching firmware precedence) with RGB565 conversion, falling back to monochrome when the referenced palette hasn't arrived. Renderer split into MirrorFrameRenderer.kt.
Controls sit beside the mirror when the content width allows (>=760dp, BoxWithConstraints) and stack below it otherwise; tapping the mirror now toggles keyboard capture instead of only acquiring it, with the hint text naming the way out.
Circular D-pad ring replaces the cross cluster (wedge hit-testing with a radial dead band, hold-to-repeat, per-wedge semantics, haptics), keyboard capture becomes an explicit chip with tap-to-toggle, and taps on touch devices forward real panel coordinates (long-press = SELECT, matching the physical touch driver). Manager gains reset() (wired to ViewModel creation and disconnect), a palette region cap, and first-chunk geometry pinning; renderer uses bit-replicated RGB565 and run-length row drawing with the pixel resolver extracted pure and tested; KeyUp of captured keys is consumed; ViewModel moved to its own file; all strings localized; the stray .bak test file is gone.
DisplayMirrorManager reassembles RGB565 rect chunks (sequence, geometry, and panel-bound validation) and composites them into a persistent little-endian RGB565 canvas emitted per completed rect; the renderer gains a true-color branch using the same run-length row drawing. Mono frames are untouched.
RGB565 frames identify LVGL/MUI devices, whose UIs read their own input drivers rather than the InputBroker remote events inject into — so the mirror hides the D-pad, keyboard, swipe, and touch affordances and says so, until an input-injection path exists. Utility helpers and the input codes move to DisplayMirrorUtils.kt.
device-ui now accepts injected input (virtual LVGL pointer + group-attached keypad bridged from the InputBroker), so the view-only treatment goes away: the D-pad navigates MUI widgets, taps forward panel coordinates, and the keyboard types. The mirror_view_only string stays for the future capability-flag path.
The mirror's keyboard capture only mapped navigation keys and silently dropped everything else, so text entry did nothing: printable characters never left the client even though the firmware already injects kb_char. Characters now go out as ANYKEY with the code point, Backspace goes as a character (so text fields delete rather than navigating back, which stays Esc's job), and the handling moves into a Modifier.remoteKeyInput extension.
Third adversarial review pass over the client side. Rect reassembly moves out of DisplayMirrorManagerImpl into MirrorRectCompositor: the manager was carrying two unrelated state machines and 14 methods. Every rect field is now validated before anything is allocated (total_size is device-controlled), geometry is latched from the chunk at offset 0 so a later chunk cannot transpose the blit, continuations must match the buffer that was actually allocated rather than their own claim, and bounds use the subtraction form because rect_x + rect_width overflows for hostile values. A rect that omits width or height covers the full panel in that axis. remoteKeyInput no longer swallows modified keys, so Cmd+Q, Ctrl+C and Alt+Tab stay with the desktop instead of being forwarded to the device. MirrorFrameRenderer tracks colorized runs as a raw Int with a sentinel rather than a boxed Color?, and MirrorFrame.hashCode includes the format so a mono and an RGB565 frame of the same size cannot collide. Drops mirror_view_only, orphaned since MUI gained remote input.
The Debug Panel is the one Settings route deliberately exempt from the `connected && !isManaged` gate every sibling carries, justified by a comment saying it "reads app-local logs only". The Mirror tab put an admin write (set_display_mirror) and arbitrary input injection on that route, so managed mode - which exists to lock a device out of configuration - was bypassed entirely. Enforced in the ViewModel, because the route will not do it: arming, one-shot frame requests, key, character and touch sends are all refused while managed. Disarming still goes through, so a stream already running is torn down when managed mode arrives mid-session. The UI gates on `active = connected && !managed` rather than offering controls that silently do nothing, and the RadioConfig comment now says what the route actually guarantees, since its old wording is what let this through. MirrorHeaderRow is split out of DisplayMirrorContent, which was at detekt's LongMethod limit and could not absorb another line.
The mirror's key capture was a focusable box, so it could never raise the soft keyboard. It now uses core/ui's RemoteKeyboardSink: the Keyboard chip raises the IME, typed text reaches the device one code point per kb_char (emoji included), Enter is OK, Esc is Back, Backspace and Tab are typed characters, and Ctrl/Alt chords stay with the host. The scroll column pads for the IME so the D-pad stays visible. Space now types a space instead of meaning OK.
…frames off the main thread
A 65536x524288 chunk wrapped `width * pages` to 0, matched `total_size = 0` and published an empty frame that crashed the renderer. The size and offset checks now run in Long and refuse a negative offset.
The D-pad went inactive in managed mode, but taps, swipes and the Keyboard chip stayed live while the view model dropped the input. `MirrorSurface` now takes `enabled`: gestures come off, the chip disables and keyboard focus clears.
Type-resolved detekt on main flags a LaunchedEffect whose body never suspends (UnnecessaryLaunchedEffect).
A continuation chunk could lower region_total and complete a short palette under a valid signature, or add more regions than the offset-0 chunk declared. Remember the total from the first chunk and reject continuations that change or overshoot it.
Only firmware with display mirroring fills DeviceMetadata.display, so a null one means set_display_mirror and get_display_frame_request would go unanswered. Gate arming and frame requests on it and tell the user why; keys predate mirroring and stay live. Also drop the em dashes from the mirror strings.
6d690aa to
dd56444
Compare
The Debug panel can only show what the app sees. This adds a Mirror tab that shows the connected device's own screen live and drives it: D-pad, keyboard, swipe, and touch on panels that have it. It consumes
DisplayFrame,DisplayPaletteandDisplayInfofrom protobufs#1054, now merged and pinned as2.8.1.22-gc858ad1-SNAPSHOT.Verified on hardware against a RAK4631 (mono OLED) and a LILYGO T-Deck (color, touch). The color path is MUI dirty rects and needs device-ui#394, which has not shipped, so a build from these branches gets the mono path only.
🌟 New Features
FromRadio.display_framechunks reassembled into frames, rendered 1:1 into anImageBitmapand upscaled nearest-neighbor. Color devices stream a signature-keyedDisplayPalette; per-region RGB565 colors apply with last-region-wins, and a frame that arrives before its palette turns color when the palette lands.SELECT_LONG, haptics, screen-reader semantics); keyboard capture through core/ui's sharedRemoteKeyboardSink(soft keyboard on Android, onekb_charper code point, arrows navigate, Enter is OK, Esc is Back, Ctrl/Alt chords stay with the host); swipe on the image, and tap or long-press forwards panel coordinates onhas_touchdevices.DeviceMetadata.displaygates the feature: only mirror-capable firmware fills it, so without it the tab shows an unsupported state and refuses to arm or request frames, while the D-pad stays live becausesend_input_eventpredates mirroring. E-ink devices get a one-shot Refresh hint, touch enables tap-to-touch.🛠️ Refactoring & Architecture
core/repository:DisplayMirrorManagerwithMirrorFrameandMirrorPalette;AdminController.setDisplayMirror,requestDisplayFrameandsendInputEventsend immediately so input never queues behind bulk admin traffic.core/data: the reassembly state machine. Contiguous offsets only, geometry pinned at the first chunk, size and region caps checked in Long before any allocation,reset()so a previous device's last screen is never shown as live.MirrorRectCompositorholds the dirty-rect path.core/service: the three admin senders oversendAdminImmediate.feature/settings: the Mirror tab (DisplayMirror.kt,DisplayMirrorViewModel.kt,DpadRing.kt,MirrorFrameRenderer.kt). The stream stops on tab dispose, ViewModel clear and disconnect. Managed mode refuses the admin write and input injection in the ViewModel and disables the controls in the UI.core/resources; two Material Symbols chevrons added.🧹 Chores
org.meshtastic:protobufsto2.8.1.22-gc858ad1-SNAPSHOT, the first master snapshot carrying [Feature Request] Send any CLI command #1054. The mavenLocal pin this branch carried is gone.SideEffectnow that type-resolved detekt flags a non-suspendingLaunchedEffect.Testing Performed
DisplayMirrorManagerImplTest: frames, palettes, drops, restarts, overflow, the caps, and a region_total fixed per palette.FromRadioPacketHandlerImplTest:display_frameanddisplay_paletterouting.MirrorColorResolverTest: region precedence and RGB565 bit replication.DisplayMirrorInputTest: one code point perkb_char, surrogate pairs, and which host keys map to device events.DisplayMirrorViewModelTest: no arm or frame request withoutDeviceMetadata.display, both with it, keys either way, and the gate opening when metadata lands.spotlessApply spotlessCheck detekt detektTypeResolved assembleDebug test allTests kmpSmokeCompile -PwarningsAsErrors=trueon the rebased branch.Known gaps, unfixed here: frame-render cost on the composition thread, and rect-reassembly panel geometry across continuation chunks.
Feature stack
Release order runs top to bottom.
DisplayMirror: frame capture and remote inputDisplayFrame,DisplayPalette,DisplayInfoand the two admin verbs (merged)capture_displaytoolingdevice-ui#394 is the blocker for the color path; until it lands and a pin bumps, every committed firmware configuration compiles the MUI path out.
Summary by CodeRabbit