Repository navigation
Conversation
8649f8c to
fdb2af9
Compare
|
Thanks for the careful write-up. The code itself is fine:
Generated by Claude Code |
|
@mbillow I pushed a92abff with the wording and docs changes:
One update on the dependency: QuiteYellow closed SmartThings-Local #115 in favor of the pure-Python engine in #117. #117 is still a draft and does not yet wire the engine into normal library sessions. I agree that this PR should wait for a release providing that support. The On Python 3.14, all 2,633 integration tests passed against published |
Why this is needed
I recovered my oven's OwnerPSK, but its raw owner UUID contains NUL. LocalThings rejects that identity even when the transport can preserve it.
The transport fix adds an optional Mbed TLS backend. This PR lets LocalThings use it.
What changed
PskAuth.validate_identity()whether the transport supports the binary identity.docs/credential-acquisition.md.The imported identity stays unchanged. Setup still requires successful authentication and the expected device ID from
/oic/d. This doesn't add credential extraction or ownership transfer.My result
My oven reports board prefix
LCD_R18_SCO_QMD_EU_22Kand profileDA-KS-OVEN-0105X. I haven't checked its retail model number yet.I recovered its existing 16-byte PSK from an account-specific SmartThings
.datencstore on rooted Android 17. I've published the scripts and procedure here.With both patches and the native backend installed, I authenticated and read the expected
/oic/didentity from macOS and my HA Linux runtime. I then imported the PSK and added the oven in HA. My certificate-based washer still loads too.My oven currently exposes only a connection-mode sensor reporting
poll, with no active observations. Authentication and setup work. Full oven entity coverage and heating controls aren't established.Tests and dependency
All 2,633 integration tests passed against the patched transport. Fresh runs before publication passed all 2,633 against both the patched and released transports. Ruff format, Ruff lint, and ty passed too.
On my HA instance, deployed-file hashes and
ha core checkpassed before I restarted HA.The manifest still accepts
smartthings-local>=0.1.21. That release safely rejects NUL identities. This PR alone won't enable them: you also need the transport patch and a compatible native build.A transport release and native packaging are still needed for a normal install to support this. I've tested one oven, not other models or long-term stability.
Related: #435. This uses the existing PSK import flow.