[4.1] fix(fileservice): backport memory cache allocator - #27584
Open
VioletQwQ-0 wants to merge 2 commits into
Open
[4.1] fix(fileservice): backport memory cache allocator#27584VioletQwQ-0 wants to merge 2 commits into
VioletQwQ-0 wants to merge 2 commits into
Conversation
VioletQwQ-0
marked this pull request as ready for review
August 25, 2026 09:34
VioletQwQ-0
requested review from
LeftHandCold,
aptend and
fengttt
as code owners
August 25, 2026 09:34
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
fengttt
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Related issues: #26992, #27567
What this PR does / why we need it:
This Draft PR backports the memory-cache backing-capacity accounting and the dedicated jemalloc allocator to
4.1-dev.The change is based on upstream PR #26997 (allocator replacement) and #26783 (backing-capacity accounting), adapted to the exact
4.1-devbase0d5195e5f93292939e2c5bca66a9746993315d25(ad93dd48c66bbabc82db3078125b36d4b3e90aaacandidate). It adds:The backport preserves the 4.1 FileService/objectio surface and does not import unrelated main-only DISK-V2, ONNX, CopyObject, or validation-pipeline changes. No SQL syntax, wire protocol, storage format, or default public configuration is changed.
This update also closes the two startup/remote-cache safety gaps identified during review:
Validation
bash -n: not applicable (no shell source changed).GOWORK=off go build -mod=readonly ./...: PASS.GOWORK=off go vet -mod=readonlyon all changed production packages: PASS.pkg/common/malloc,pkg/fileservice/fifocache,pkg/fileservice, andpkg/objectio: PASS.-race -count=2, PASS; one full owning-package race run, PASS.3826bc80232f22ed5c4662f3034f799ca316e819103bdc7bb99018a421706f92, local static build PASS.The combined
pkg/fileservice+pkg/embedpackage run remains affected by the existingTestDefaultTmpFileServiceUsesServiceDataDirbaseline failure (the default TMP config has an empty data directory); the new tests and all affected production packages compile, vet, and pass their targeted normal/CGo/race runs.QA is required before this Draft is made Ready. This PR does not deploy to mo-50 and does not claim the #26992 workload has been rerun on 4.1-dev.