Skip to content

bug: events client passing incorrect parameter name when checking cur… #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathsman5133 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bug: events client passing incorrect parameter name when checking cur… #286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73386e4
bug: events client passing incorrect parameter name when checking cur…
mathsman5133 Apr 12, 2026
eb8eb82
Fix cache war lookup bug where superfluous events are triggered becau…
mathsman5133 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions coc/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ async def _run_war_update(self, clan_tag, cwl_round=None):
meth = self.get_clan_war

try:
war = await meth(clan_tag, cls=self.war_cls, round=cwl_round)
war = await meth(clan_tag, cls=self.war_cls, cwl_round=cwl_round)
except (Maintenance, PrivateWarLog):
self._safe_unlock(lock)
return
Expand All @@ -1109,8 +1109,9 @@ async def _run_war_update(self, clan_tag, cwl_round=None):
# sleep for either the global retry or whenever a new war object is available, whichever is smaller.
self.loop.call_later(max(war._response_retry, self.war_retry_interval), self._safe_unlock, lock)

cached_war = self._get_cached_war(clan_tag)
self._update_war(clan_tag, war)
# use war:cwl_round:clan_tag key to fetch the right war during cwl
cached_war = self._get_cached_war(key)
self._update_war(key, war)

if not cached_war:
self._safe_unlock(lock)
Expand Down
Loading