Repository navigation
fix(ci): narrow dataprep prereq changes - #94
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR migrates multiple Makefiles and Travis CI configuration from the "docker compose" plugin to an explicit "docker-compose" binary, adding download/packaging steps and smoke-check commands. It also simplifies an SSH wait-ssh retry probe and its test, plus makes minor unrelated env/version tweaks. ChangesDocker Compose CLI Migration
SSH Wait-SSH Retry Simplification
Misc Build Config Cleanup
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
make version config/ backend version resolution from hanging.maildev/maildev:2.2.1, which keeps/emailcompatible and avoids the vulnerable2.0.5pin.Validation
maildev/maildev:2.2.1local Docker probe:GET /emailreturns[].git diff --check origin/main..HEADmake version config GIT_BRANCH=fix/narrow-dataprep-prereq-changesmake frontend-docker-check GIT_BRANCH=fix/narrow-dataprep-prereq-changesmake -C packages/deces-backend DATA_DIR=data NPM_AUDIT_DRY_RUN=true docker-check-backend GIT_BRANCH=fix/narrow-dataprep-prereq-changesTrace
PR #93 was merged at
ed7d1b96before this cleanup. This PR carries the cleanup ontomainexplicitly.Summary by CodeRabbit
New Features
docker-composeavailability during remote validation.docker-composeversion with packaged tooling and install flows for more consistent setup.Bug Fixes
docker-composeby standardizing command handling.Tests