Repository navigation
fix(cd): restore dataprep monthly schedule, publish only new snapshots - #112
Merged
Merged
Conversation
#92 made dataprep-monthly manual-only as a stopgap while Scaleway PRO2-L workers failed SSH and leaked on retries. The SSH path was fixed since (cf69b5b, d31864b) and runs succeed again, but the 4-hour schedule never came back, so new INSEE months waited for a manual dispatch. Restoring it as is would cut a prod release per poll: dispatch-release-prod ran unconditionally, and the 2026-10-09 manual run already re-tagged and redeployed an unchanged snapshot (v2026.10.09.1). The dispatch now requires force_restore, which is true only when the snapshot differs from the one last published. prod-publication-guardrails.sh asserts both; it was failing on main since #92 dropped the cron.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
3 */4 * * *schedule as a stopgap (PRO2-L SSH failures leaking workers). The SSH path was fixed since (cf69b5b, d31864b) and manual runs succeed (2026-08-13, 2026-09-13, 2026-10-09, 2026-10-10), but the schedule never came back: new INSEE months wait for a manual dispatch.dispatch-release-prodhad no condition: the 2026-10-09 run found no new data and still cutv2026.10.09.1and redeployed the same snapshot. With the schedule back, that would be up to 6 prod releases a day.What
dispatch-release-prodruns only whenforce_restore == 'true'(snapshot differs from the last published one); otherwise the job is skipped and the run stays green,notify-failureonly fires onfailureprod-publication-guardrails.shasserts the guard; the test was failing on main since chore(cd): make dataprep monthly manual only #92Cost of an idle poll
full-checkon the runner finds the snapshot in the repository and touchesno-remote, soremote-allstarts no Scaleway worker; the zone step only does API reads.Validation
bash deploy/k8s/tests/prod-publication-guardrails.shpasses (fails on main: "dataprep-monthly must scan every 4 hours")on.schedule = [{cron: '3 */4 * * *'}],dispatch-release-prod.ifset