Repository navigation
MLE-26255: Merge Master back to develop - #121
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the operator release metadata and improves lifecycle hook logging behavior as part of merging changes back into develop.
Changes:
- Bumps operator/chart/image versions from
1.1.0to1.1.1across manifests, Helm chart, docs, and build tooling. - Updates copyright headers to
2024-2026. - Adjusts postStart/preStop hook scripts to write logs to
/proc/1/fd/1instead of resolving the MarkLogic PID.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/6_log_collection_test.go | Copyright year bump. |
| test/e2e/4_tls_test.go | Copyright year bump. |
| pkg/k8sutil/statefulset.go | Copyright year bump. |
| pkg/k8sutil/configmap.go | Copyright year bump. |
| pkg/k8sutil/scripts/prestop-hook.sh | Changes hook logging target to PID 1 stdout FD. |
| pkg/k8sutil/scripts/poststart-hook.sh | Changes hook logging target to PID 1 stdout FD; removes PID lookup. |
| config/manager/kustomization.yaml | Updates controller image tag to 1.1.1. |
| charts/marklogic-operator-kubernetes/values.yaml | Updates chart values image tag to 1.1.1. |
| charts/marklogic-operator-kubernetes/Chart.yaml | Updates chart version and appVersion to 1.1.1. |
| README.md | Updates Helm install/upgrade example to 1.1.1. |
| NOTICE.txt | Copyright year bump. |
| Makefile | Updates default VERSION to 1.1.1. |
| LICENSE | Copyright year bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [ -n "$pid" ]; then | ||
| echo "${TIMESTAMP} $@" > /proc/$pid/fd/1 | ||
| fi | ||
| echo "${TIMESTAMP} $@" > /proc/1/fd/1 |
There was a problem hiding this comment.
Logging now unconditionally redirects to /proc/1/fd/1. If that FD is not writable/available in a given container environment, the redirection will fail and can cause the preStop hook to fail (potentially impacting pod termination behavior). Consider adding a safe fallback (e.g., write to stdout if the /proc/1/fd/1 write fails) or explicitly ignore redirection errors so the hook logic remains reliable.
| echo "${TIMESTAMP} $@" > /proc/1/fd/1 | |
| echo "${TIMESTAMP} $@" > /proc/1/fd/1 2>/dev/null || echo "${TIMESTAMP} $@" |
| echo $message > /proc/1/fd/1 | ||
| echo $message >> /tmp/script.log |
There was a problem hiding this comment.
The $message variable should be quoted to avoid word-splitting and glob expansion (which can alter log output and, in edge cases, cause unexpected behavior). Update these to use echo \"$message\" ... (or printf '%s\\n' \"$message\" ...) for stable, predictable logging.
| echo $message > /proc/1/fd/1 | |
| echo $message >> /tmp/script.log | |
| echo "$message" > /proc/1/fd/1 | |
| echo "$message" >> /tmp/script.log |
No description provided.