Repository navigation
MLE-32900: Exclude UBI packages from Docker NOTICE scan - #488
Open
vitalykorolev wants to merge 1 commit into
Open
vitalykorolev wants to merge 1 commit into
vitalykorolev wants to merge 1 commit into
Conversation
Split deps Dockerfiles into a platform stage containing the UBI base and all UBI-repo packages, and a deps stage containing Rocky libnsl. Publish the platform image and pass it as BASE_IMAGE_TO_EXCLUDE so the Black Duck NOTICE scan excludes UBI-repo packages, but not libnsl or MarkLogic. Keep sudo absent from rootless images.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Server templates still perform UBI package transactions outside the platform boundary, and the new exclusion behavior lacks automated coverage.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Splits UBI-provided dependencies into a dedicated platform image for Black Duck NOTICE exclusions.
Changes:
- Adds platform/dependency Docker stages and relocates UBI packages.
- Builds, archives, publishes, and scans against platform images.
- Documents the new package-boundary convention.
| File | Description |
|---|---|
Makefile |
Builds platform and dependency images. |
Jenkinsfile |
Publishes and supplies platform images to Black Duck. |
dockerFiles/marklogic-server-ubi9-arm:base |
Inherits sudo from the platform. |
dockerFiles/marklogic-server-ubi:base |
Inherits sudo from the platform. |
dockerFiles/marklogic-server-ubi-rootless:base |
Inherits libcap from the platform. |
dockerFiles/marklogic-deps-ubi9:base |
Adds UBI9 platform/deps stages. |
dockerFiles/marklogic-deps-ubi9-arm:base |
Adds ARM platform/deps stages. |
dockerFiles/marklogic-deps-ubi:base |
Adds UBI8 platform/deps stages. |
.github/copilot-instructions.md |
Documents package-placement requirements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Black Duck NOTICE scan of Docker images must exclude the UBI base and all
packages installed from UBI repositories, but not libnsl (Rocky rpm).
platformstage (UBI base, allmicrodnf installs, FIPS policy) and a
depsstage (adds the Rocky libnsl rpm).PLATFORM_EXTRA_PACKAGES (empty for rootless images). The server Dockerfiles
no longer install sudo or libcap.
(internal registry only) and passes it as BASE_IMAGE_TO_EXCLUDE to the Black Duck job.
Requires the companion securityscans PR (MLE-32900).
Checklist:
Owner:
JIRA_ID as part of branch/PR name
Rebase the branch with upstream
Squashed all commits into a single commit
Added Tests
Reviewer:
Reviewed Tests
Added to Release Wiki/Jira