Repository navigation
MLE-32821: Docker pipeline - potential issue - #487
Merged
Merged
Conversation
vitalykorolev
requested review from
barkhachoithani,
pengzhouml,
rwinieski and
sumanthravipati
September 29, 2026 01:41
rwinieski
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four issues identified during the most recent release: incorrect relative path resolution in the docker-tests Makefile target, invalid YAML indentation in a cluster Compose file, unsafe BRANCH_NAME usage in the Jenkinsfile, and non-copy/paste-safe docker run examples in the README.
Root cause
The docker-tests recipe changed directory before resolving docker-test-ids, a Compose service key was mis-indented, BRANCH_NAME was referenced without the env. prefix outside multibranch pipeline context, and README docker run examples contained inline comments that broke shell line-continuation on copy/paste.
Fix
Reordered the docker-tests Makefile recipe, re-indented bootstrap_2n in compose-2node-bootstrap-only.yaml, changed both BRANCH_NAME references to env.BRANCH_NAME in resultNotification(), and moved the SYS_PTRACE guidance out of the docker run code blocks into prose above each example.
Validation