Translations update from Hosted Weblate#472
Conversation
Reviewer's GuideThis PR updates Vietnamese and French localizations, improving translation quality, consistency, and coverage across many UI strings, preferences, and messages, while also adding missing plural forms in French. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- In the Vietnamese strings, there are a couple of typos and consistency issues (e.g., "lyrics_were_updated_successfully" uses "bái hát" instead of "bài hát", and "lyrics_bold_synced_summary" has "vơi" instead of "với"), and terms like "phông chữ" / "font chữ" and "EQ" / "Eq" are mixed—consider standardizing these across the file.
- For the French translations, you’ve added "many" plural forms, but Android’s quantity handling for French typically only distinguishes "one" and "other"; confirm that adding "many" is intentional and supported by your pluralization logic, otherwise these entries may be ignored.
- In French, some strings now mix "playlist" and "liste de lecture" (e.g., "no_playlists_that_match_x" and "songs_added_to_playlists"); it would be good to unify the terminology to one of the two for consistency in the UI.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the Vietnamese strings, there are a couple of typos and consistency issues (e.g., "lyrics_were_updated_successfully" uses "bái hát" instead of "bài hát", and "lyrics_bold_synced_summary" has "vơi" instead of "với"), and terms like "phông chữ" / "font chữ" and "EQ" / "Eq" are mixed—consider standardizing these across the file.
- For the French translations, you’ve added "many" plural forms, but Android’s quantity handling for French typically only distinguishes "one" and "other"; confirm that adding "many" is intentional and supported by your pluralization logic, otherwise these entries may be ignored.
- In French, some strings now mix "playlist" and "liste de lecture" (e.g., "no_playlists_that_match_x" and "songs_added_to_playlists"); it would be good to unify the terminology to one of the two for consistency in the UI.
## Individual Comments
### Comment 1
<location path="app/src/main/res/values-vi-rVN/strings.xml" line_range="469" />
<code_context>
+ <string name="failed_to_update_lyrics">Cập nhật lời bài hát thất bại.</string>
+ <string name="there_are_no_changes_to_save">Không có thay đổi nào để lưu.</string>
+ <string name="font_imported_successfully">Thêm phông chữ thành công.</string>
+ <string name="could_not_import_font">Không thể thêm font chữ.</string>
<!-- Sleep timer -->
<string name="action_sleep_timer">Hẹn giờ ngủ</string>
</code_context>
<issue_to_address>
**suggestion (typo):** Inconsistent terminology between “phông chữ” and “font chữ”.
`font_imported_successfully` uses “phông chữ” while `could_not_import_font` uses “font chữ”. Please align the wording in both strings (e.g., use “phông chữ” in both).
```suggestion
<string name="could_not_import_font">Không thể thêm phông chữ.</string>
```
</issue_to_address>
### Comment 2
<location path="app/src/main/res/values-vi-rVN/strings.xml" line_range="898-901" />
<code_context>
+ <string name="lastfm_login_title">Đăng nhập vào Last.fm</string>
+ <string name="mini_player_swipe_to_skip_summary">Vuốt trái hoặc phải trên trình phát thu nhỏ để chuyển bài.</string>
+ <string name="lyrics_karaoke_style_title">Lời bài hát kiểu karaoke</string>
+ <string name="lyrics_bold_synced_title">Font in đậm cho lời bài hát đã đồng bộ</string>
+ <string name="lyrics_by_x">Lời bài hát bởi %s</string>
+ <string name="lyrics_karaoke_style_summary">Kích hoạt hiệu ứng kiểu Karaoke cho lời bài hát đồng bộ từng từ. Lưu ý rằng đây là một tính năng thử nghiệm.</string>
+ <string name="lyrics_bold_synced_summary">Hiển thị lời bài hát đồng bộ vơi font in đậm</string>
+ <string name="listenbrainz_login_title">Đăng nhập vào ListenBrainz</string>
+ <string name="sleep_timer_x_secs">%d giây</string>
</code_context>
<issue_to_address>
**issue (typo):** Typos and mixed English/Vietnamese in the bold-synced-lyrics strings.
In `lyrics_bold_synced_summary`, “vơi” should be “với”. Also consider avoiding the English “font” in these Vietnamese strings; e.g. use `phông chữ in đậm cho lời bài hát đã đồng bộ` and `Hiển thị lời bài hát đã đồng bộ với phông chữ in đậm` for consistency with nearby terminology.
Suggested implementation:
```
<string name="lyrics_bold_synced_title">Phông chữ in đậm cho lời bài hát đã đồng bộ</string>
```
```
<string name="lyrics_bold_synced_summary">Hiển thị lời bài hát đã đồng bộ với phông chữ in đậm</string>
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| <string name="failed_to_update_lyrics">Cập nhật lời bài hát thất bại.</string> | ||
| <string name="there_are_no_changes_to_save">Không có thay đổi nào để lưu.</string> | ||
| <string name="font_imported_successfully">Thêm phông chữ thành công.</string> | ||
| <string name="could_not_import_font">Không thể thêm font chữ.</string> |
There was a problem hiding this comment.
suggestion (typo): Inconsistent terminology between “phông chữ” and “font chữ”.
font_imported_successfully uses “phông chữ” while could_not_import_font uses “font chữ”. Please align the wording in both strings (e.g., use “phông chữ” in both).
| <string name="could_not_import_font">Không thể thêm font chữ.</string> | |
| <string name="could_not_import_font">Không thể thêm phông chữ.</string> |
| <string name="lyrics_bold_synced_title">Font in đậm cho lời bài hát đã đồng bộ</string> | ||
| <string name="lyrics_by_x">Lời bài hát bởi %s</string> | ||
| <string name="lyrics_karaoke_style_summary">Kích hoạt hiệu ứng kiểu Karaoke cho lời bài hát đồng bộ từng từ. Lưu ý rằng đây là một tính năng thử nghiệm.</string> | ||
| <string name="lyrics_bold_synced_summary">Hiển thị lời bài hát đồng bộ vơi font in đậm</string> |
There was a problem hiding this comment.
issue (typo): Typos and mixed English/Vietnamese in the bold-synced-lyrics strings.
In lyrics_bold_synced_summary, “vơi” should be “với”. Also consider avoiding the English “font” in these Vietnamese strings; e.g. use phông chữ in đậm cho lời bài hát đã đồng bộ and Hiển thị lời bài hát đã đồng bộ với phông chữ in đậm for consistency with nearby terminology.
Suggested implementation:
<string name="lyrics_bold_synced_title">Phông chữ in đậm cho lời bài hát đã đồng bộ</string>
<string name="lyrics_bold_synced_summary">Hiển thị lời bài hát đã đồng bộ với phông chữ in đậm</string>
1342225 to
35f84fe
Compare
Currently translated at 100.0% (920 of 920 strings) Translation: Booming Music/Strings Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/fr/
Currently translated at 71.8% (661 of 920 strings) Translation: Booming Music/Strings Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/vi/
Currently translated at 12.0% (111 of 920 strings) Translation: Booming Music/Strings Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/kk/
Translation: Booming Music/Strings Language: German Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/de/
Translation: Booming Music/Strings Language: Spanish (American) Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/es_US/
Translation: Booming Music/Strings Language: French Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/fr/
Translation: Booming Music/Strings Language: Italian Progress: 99.4% (921 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/it/
Translation: Booming Music/Strings Language: Chinese (Simplified Han script) Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/zh_Hans/
Translation: Booming Music/Strings Language: Italian Progress: 99.5% (922 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/it/
Translation: Booming Music/Strings Language: Swedish Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/sv/
Translation: Booming Music/Strings Language: Swedish Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/sv/
Translation: Booming Music/Strings Language: Ukrainian Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/uk/
Translation: Booming Music/Strings Language: Spanish Progress: 100.0% (926 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/es/
Translation: Booming Music/Strings Language: Luri (Bakhtiari) Progress: 22.6% (210 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/bqi/
Translation: Booming Music/Strings Language: Estonian Progress: 99.4% (921 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/et/
Translation: Booming Music/Strings Language: Luri (Bakhtiari) Progress: 27.7% (257 of 926 strings) Translate-URL: https://hosted.weblate.org/projects/booming-music/strings/bqi/
8c98c4f to
10b80cb
Compare
Translations update from Hosted Weblate for Booming Music/Strings.
Current translation status:
Summary by Sourcery
Update localized string resources for Vietnamese and French translations across the app.
Enhancements: