Use OS-independent path for generated figure - #162
Open
AndreyBunchuk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix generated map path on Windows
Problem
When running PrettyMaps on Windows, a
FileNotFoundErroroccurs when trying to open the generated map file:The error occurs in
app.pywhen opening the generated file:The hardcoded
/tmp/path is Unix-specific and does not work correctly on Windows.Solution
Replaced the hardcoded path with an OS-independent temporary directory:
This uses the appropriate temporary directory for the operating system.
Result
The map generation and download functionality now works correctly on Windows while remaining compatible with Unix-based systems.