Log swallowed OSM fetch errors and guard missing 'highway' column - #160
Open
fotisanpetprojects wants to merge 1 commit into
Open
Log swallowed OSM fetch errors and guard missing 'highway' column#160fotisanpetprojects wants to merge 1 commit into
fotisanpetprojects wants to merge 1 commit into
Conversation
fetch.py caught every exception during Overpass fetches and silently returned an empty GeoDataFrame, with no indication of what failed (rate limit, timeout, malformed response). This made failures undebuggable and led to a downstream KeyError: 'highway' in graph_to_shapely when a street-layer fetch failed and left the gdf without a 'highway' column. - fetch.py: log the exception instead of discarding it silently - draw.py: fall back to NaN width when 'highway' is missing, instead of crashing Fixes marceloprates#159, marceloprates#154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159, Fixes #154
fetch.pyhad two bareexcept Exception:blocks that silently discarded every error during Overpass/OSM fetches (rate limits, timeouts, malformed responses), returning an emptyGeoDataFramewith no trace of what failed. One of them even had its diagnosticprintcommented out.This made failures undebuggable, and could cascade into a
KeyError: 'highway'crash indraw.py'sgraph_to_shapelywhen a failed street-layer fetch left the GeoDataFrame without ahighwaycolumn.Changes:
fetch.py: log the exception vialogging.warninginstead of discarding it silently (both call sites)draw.py: fall back toNaNwidth whenhighwayis missing instead of crashing, so the layer is just dropped (same as the existing "no known width" path)Tested: full
pytestsuite passes (9/9), plus manual smoke-test renders across several locations.