fix(ddl)!: report unknown column type errors clearly - #4933
Open
donhardman wants to merge 2 commits into
Open
donhardman wants to merge 2 commits into
donhardman wants to merge 2 commits into
Conversation
DDL validation now reports unsupported or missing types more specifically and suggests database types where applicable. - stop recognizing DOUBLE as a dedicated DDL token - suggest database types for unknown column types - report missing or unsupported types for required id columns - improve UUID column type validation errors BREAKING CHANGE: DOUBLE is no longer accepted as a dedicated DDL column type.
klirichek
requested changes
Sep 25, 2026
klirichek
left a comment
Contributor
There was a problem hiding this comment.
That is perfectly feature to be tested with an ubertest. Why no one provided?
Member
Author
|
Added tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misleading
CREATE TABLEerrors for unsupported column types (doubleetc.)Before
After
doubleis no longer a reserved word, so it can now be used as a column name.