fix: reduce infix merge memory usage - #4881
Closed
sanikolaev wants to merge 1 commit into
Closed
sanikolaev wants to merge 1 commit into
sanikolaev wants to merge 1 commit into
Conversation
- store the infix arena and long UTF-8 keys in bounded segments - compact short keys and one/two-checkpoint lists inline - sort arena blocks and serialize them with a k-way merge - honor min_infix_len throughout indexing and merge paths - release builder storage as soon as infix entries are written - add a local peak-RSS benchmark Related issue: #4850
Collaborator
Author
|
Benchmarks show that this approach doesn't lead to significant improvements. |
Collaborator
Author
The command I tested with was: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #4850