feat: add move_client - #1284
Open
Sora3e8 wants to merge 2 commits into
Open
Conversation
Contributor
|
https://github.com/mangowm/mango/blob/main/.github/CONTRIBUTING.md Squash all commit into one, and idk if need run |
- Inspired by previous pull request mangowm#1022 - Synced with current codebase - Fixed crossmonitor behavior, windows can jump from monitor to monitor Spec description: - When move_client,dir is sent window is moved into that direction - If window hits and edge of a monitor the window will be moved to next monitor if a monitor exists in that direction, otherwise nothing will happen.
Author
|
@Wateir Regarding the format, I was running the format script through out the process, it's possible I might have forgot to trigger it. I tried to run it just in case and I do not see any new diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by previous pull request #1022
Previously requested in Feature request #942
Changes done in comparison to #1022
Spec description:
otherwise nothing will happen.
Note:
so it would go to x=0 or y=0 again, but the conditions proved troublesome and probably would be good to have a new config for that as well... so I stuck with blocking if no other monitor is in the direction.
this seems to be primarily caused by way which the functions retrieving client in certain direction work.