Repository navigation
Snowflake: key-pair auth from a Malloy config file - #3172
Merged
Merged
Conversation
Declare the authenticator property, and default it to SNOWFLAKE_JWT when a private key is given without one. Fixes #3046
Also type the createPool spy in the config test.
The driver ignores an empty privateKeyPath, so it must not switch a password login to key-pair auth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3046. Snowflake key-pair auth couldn't be set up from a Malloy config file. snowflake-sdk only uses the key when
authenticatorisSNOWFLAKE_JWT, andauthenticatorwasn't a declared property, so the config compiler dropped it and the driver asked for a password.authenticatoris now declared, and a private key given without one impliesSNOWFLAKE_JWT, so a config that supplies only the key works as written.A config with both a password and a key, and no authenticator, used to log in with the password; it now uses the key.
Along the way we also:
privateKeyto the Snowflake property list inpackages/malloy/src/connection/CONTEXT.mdFollowup:
authenticatorto the Snowflake table in malloydata.github.iosrc/documentation/setup/config.malloynb, noting that a key takes precedence over a password