Repository navigation
Tag.toString() quotes string values that would read back as numbers - #3141
Merged
Merged
Conversation
A string value is written bare only when it starts with a letter or underscore. The renderer's chart-settings writers pass numbers instead of stringified numbers. Fixes #3139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3139.
Tag.toString()wrote any string matching[0-9A-Za-z_]+without quotes, so a string like"007"read back as the number 7.Code that wrote a number into a tag as a string, relying on it to come back a number, now gets a string. The renderer's chart-settings writers did this; they now pass the numbers.